From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35741) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRRbw-0001ag-BK for qemu-devel@nongnu.org; Fri, 18 Nov 2011 11:48:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RRRbt-0005FR-Om for qemu-devel@nongnu.org; Fri, 18 Nov 2011 11:48:20 -0500 Received: from mail-ww0-f53.google.com ([74.125.82.53]:41298) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRRbt-0005F6-KI for qemu-devel@nongnu.org; Fri, 18 Nov 2011 11:48:17 -0500 Received: by wwf27 with SMTP id 27so5009862wwf.10 for ; Fri, 18 Nov 2011 08:48:16 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1321542834-6880-1-git-send-email-kwolf@redhat.com> References: <1321542834-6880-1-git-send-email-kwolf@redhat.com> Date: Fri, 18 Nov 2011 16:48:16 +0000 Message-ID: From: Stefan Hajnoczi Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [Qemu-devel] [PATCH 0/8] qcow2: Fix error paths for internal snapshots List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Thu, Nov 17, 2011 at 3:13 PM, Kevin Wolf wrote: > This is more or less the same kind of fixes that we made in the rest of qcow2 > last year: Return the right error codes and make the order of operations safe > so that a crash can lead to no more than cluster leaks. > > Although all of these are bug fixes, I'm not so sure about taking them into > 1.0. Maybe we can take some of the easier ones and leave others out, or just > move the whole series to 1.1. Feedback on this would appreciated. Thanks Kevin. I left comments on individual patches. I'll review v2 from scratch again because these changes can be subtle. Stefan