From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6IAs-00071B-Bb for qemu-devel@nongnu.org; Wed, 21 Sep 2011 04:28:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R6IAr-0005vc-1V for qemu-devel@nongnu.org; Wed, 21 Sep 2011 04:28:58 -0400 Received: from mail-yw0-f45.google.com ([209.85.213.45]:45280) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R6IAq-0005vX-TX for qemu-devel@nongnu.org; Wed, 21 Sep 2011 04:28:57 -0400 Received: by ywm39 with SMTP id 39so1228955ywm.4 for ; Wed, 21 Sep 2011 01:28:56 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20110920162253.GA26358@Krystal> References: <20110916165933.16620.4383.stgit@ginnungagap.bsc.es> <20110916165938.16620.54932.stgit@ginnungagap.bsc.es> <20110920115202.GB23976@stefanha-thinkpad.localdomain> <87ty87z849.fsf@ginnungagap.bsc.es> <20110920143112.GA14814@Krystal> <20110920162253.GA26358@Krystal> Date: Wed, 21 Sep 2011 09:28:55 +0100 Message-ID: From: Stefan Hajnoczi Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [ltt-dev] [PATCH 2/3] trace: [ust] Do not use 'm' in event argument names (used by ust macros) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mathieu Desnoyers Cc: ltt-dev@lists.casi.polymtl.ca, =?ISO-8859-1?Q?Llu=EDs_Vilanova?= , qemu-devel@nongnu.org On Tue, Sep 20, 2011 at 5:22 PM, Mathieu Desnoyers wrote: > * Stefan Hajnoczi (stefanha@gmail.com) wrote: >> 2011/9/20 Mathieu Desnoyers : >> > * Llu=EDs Vilanova (vilanova@ac.upc.edu) wrote: >> >> Stefan Hajnoczi writes: >> >> >> >> > On Fri, Sep 16, 2011 at 06:59:38PM +0200, Llu=EDs Vilanova wrote: >> >> >> Signed-off-by: Llu=EDs Vilanova >> >> >> --- >> >> >> trace-events | =A0 =A04 ++-- >> >> >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> >> >> >> >> diff --git a/trace-events b/trace-events >> >> >> index 9d1fbbb..b653d70 100644 >> >> >> --- a/trace-events >> >> >> +++ b/trace-events >> >> >> @@ -418,8 +418,8 @@ milkymist_pfpu_pulse_irq(void) "Pulse IRQ" >> >> >> # hw/milkymist-softusb.c >> >> >> milkymist_softusb_memory_read(uint32_t addr, uint32_t value) "addr= %08x value %08x" >> >> >> milkymist_softusb_memory_write(uint32_t addr, uint32_t value) "add= r %08x value %08x" >> >> >> -milkymist_softusb_mevt(uint8_t m) "m %d" >> >> >> -milkymist_softusb_kevt(uint8_t m) "m %d" >> >> >> +milkymist_softusb_mevt(uint8_t _m) "m %d" >> >> >> +milkymist_softusb_kevt(uint8_t _m) "m %d" >> >> >> >> > The LTTng community has been very responsive in addressing namespac= e >> >> > issues with libust. =A0Let's post more details and see if it can be= fixed >> >> > in libust. >> >> >> >> > Could you please post your gcc and libust versions? >> >> >> >> > I have not been able to reproduce the problem on Debian libust-dev >> >> > 0.15-3. =A0My gcc version is Debian gcc 4.6.1-4. >> >> >> >> Yup, I was using libust-dev 0.5 (debian stable). After switching to 0= .15 (debian >> >> testing) other problems arise. >> >> >> >> For example, in my box compiling osdep.c yields lots of "variable =91= __tp_cb_data=92 >> >> set but not used", but using a minimal example does not raise such pr= oblems, so >> >> I'm assuming this is related to some namespace problems related to so= me other >> >> code in qemu's headers. >> > >> > If you can find a few minutes to provide: >> > >> > 1) a link to the git repository/commit ID you are testing >> > 2) the exact configuration you use (detailed way to reproduce the >> > =A0 problem, as a sequence of commands from a pristine repository) >> > >> > It will allow me to look into this warning and fix it. >> >> AFAICT the only problem with libust is the __tp_cb_data set but not >> used warning that gcc 4.6 emits, see my test program: >> >> #include >> #include >> >> DECLARE_TRACE(ust_milkymist_softusb_mevt, TP_PROTO(uint8_t m), >> TP_ARGS(m)); >> >> int main(int argc, char **argv) >> { >> =A0 =A0 =A0 =A0return 0; >> } >> >> You will get an error with gcc 4.6 and libust 0.15: >> >> $ gcc -o a -Wall a.c > > Ah, I see. This is due to the backward compatibility API I added in > 0.15 for qemu. It skips using the __tp_cb_data private data. So it does > make sense that the compiler complains about this. I can add a > __attribute__((unused)), as proposed by Llu=EDs. > >> >> QEMU itself does have one problem with libust 0.15. =A0We do >> DECLARE_TRACE(name, TP_PROTO(void), TP_ARGS()). =A0This results in a >> compiler error but we can fix this my changing our tracepoints to use >> DECLARE_TRACE(name, TP_PROTO(), TP_ARGS()) I think. =A0Perhaps libust's >> behavior here has changed, it shouldn't be hard to update QEMU's >> tracetool tracepoint generator though. > > For tracepoints without arguments, you need to use something like: > > TRACEPOINT_EVENT_NOARGS(name, TP_FIELDS()) > > (note: the full support of TP_FIELDS() declaration will come in UST 2.0. > For UST 0.15, it's just ignored) > > The _NOARGS variant lets you handle the (void) 0 parameter case. Okay, this is the fault of QEMU's tracetool script, which generates the LTTng UST tracepoints. We can move to the new TRACEPOINT*() macros and use _NOARGS as appropriate. Stefan