From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46567) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRPDW-0006dY-1Y for qemu-devel@nongnu.org; Fri, 18 Nov 2011 09:15:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RRPDV-0005JE-2V for qemu-devel@nongnu.org; Fri, 18 Nov 2011 09:14:58 -0500 Received: from mail-ww0-f53.google.com ([74.125.82.53]:47378) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RRPDU-0005JA-US for qemu-devel@nongnu.org; Fri, 18 Nov 2011 09:14:57 -0500 Received: by wwf27 with SMTP id 27so4747886wwf.10 for ; Fri, 18 Nov 2011 06:14:56 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1321542834-6880-3-git-send-email-kwolf@redhat.com> References: <1321542834-6880-1-git-send-email-kwolf@redhat.com> <1321542834-6880-3-git-send-email-kwolf@redhat.com> Date: Fri, 18 Nov 2011 14:14:56 +0000 Message-ID: From: Stefan Hajnoczi Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/8] qcow2: Return real error code in qcow2_write_snapshots List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Thu, Nov 17, 2011 at 3:13 PM, Kevin Wolf wrote: > - =A0 =A0/* update the various header fields */ > + =A0 =A0/* > + =A0 =A0 * Update the header to point to the new snapshot table. This re= quires the > + =A0 =A0 * new table and its refcounts to be stable on disk. > + =A0 =A0 * > + =A0 =A0 * FIXME This should be done with a single write The nb_snapshots and snapshots_offset writes can be easily combined since the fields are adjacent in QcowHeader. I think it's worth changing the code to do it in this patch series instead of leaving a FIXME comment. Stefan