From: Stefan Hajnoczi <stefanha@gmail.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: qemu devel list <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] a suggestion to place *.c hunks last in patches
Date: Wed, 30 Nov 2016 15:35:09 +0000 [thread overview]
Message-ID: <CAJSP0QXZ4S6OzZ6pLQRjSG=fDJv_n=zCLVnK-S5neMoEbt9AxQ@mail.gmail.com> (raw)
In-Reply-To: <9151aa4b-44ed-ee0f-4dac-581931b3e899@redhat.com>
On Wed, Nov 30, 2016 at 10:08 AM, Laszlo Ersek <lersek@redhat.com> wrote:
> Recent git releases support the diff.orderFile permanent setting. (In
> older releases, the -O option had to be specified on the command line,
> or in aliases, for the same effect, which was quite inconvenient.) From
> git-diff(1):
>
> -O<orderfile>
> Output the patch in the order specified in the <orderfile>,
> which has one shell glob pattern per line. This overrides
> the diff.orderFile configuration variable (see git-
> config(1)). To cancel diff.orderFile, use -O/dev/null.
>
> In my experience, an order file such as:
>
> configure
> *Makefile*
> *.json
> *.txt
> *.h
> *.c
>
> that is, a priority order that goes from
> descriptive/declarative/abstract to imperative/specific works wonders
> for reviewing.
Thanks, you are a gentleman and a scholar!
I've set it in my global git config.
Stefan
next prev parent reply other threads:[~2016-11-30 15:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 10:08 [Qemu-devel] a suggestion to place *.c hunks last in patches Laszlo Ersek
2016-11-30 10:55 ` Gerd Hoffmann
2016-11-30 12:03 ` Laszlo Ersek
2016-11-30 12:27 ` Fam Zheng
2016-12-02 10:15 ` Laszlo Ersek
2016-11-30 12:29 ` Gerd Hoffmann
2016-11-30 15:36 ` Laszlo Ersek
2016-11-30 20:48 ` John Snow
2016-11-30 21:54 ` Laszlo Ersek
2016-12-02 10:23 ` Stefan Hajnoczi
2016-11-30 15:08 ` Michael S. Tsirkin
2016-11-30 15:26 ` Laszlo Ersek
2016-11-30 18:31 ` Michael S. Tsirkin
2016-11-30 15:35 ` Stefan Hajnoczi [this message]
2016-11-30 15:41 ` Eric Blake
2016-11-30 20:02 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJSP0QXZ4S6OzZ6pLQRjSG=fDJv_n=zCLVnK-S5neMoEbt9AxQ@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).