From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46341)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Qyjja-0000D2-4d
	for qemu-devel@nongnu.org; Wed, 31 Aug 2011 08:17:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QyjjV-0004h0-Ut
	for qemu-devel@nongnu.org; Wed, 31 Aug 2011 08:17:34 -0400
Received: from mail-gy0-f173.google.com ([209.85.160.173]:38644)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QyjjV-0004gm-RU
	for qemu-devel@nongnu.org; Wed, 31 Aug 2011 08:17:29 -0400
Received: by gyd12 with SMTP id 12so532018gyd.4
	for <qemu-devel@nongnu.org>; Wed, 31 Aug 2011 05:17:29 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20110825191731.1413.26838.stgit@ginnungagap.bsc.es>
References: <20110825191731.1413.26838.stgit@ginnungagap.bsc.es>
Date: Wed, 31 Aug 2011 13:17:29 +0100
Message-ID: <CAJSP0QXZVKdSX8BFKywN6CREHf9P768taR6_Gdfk03McSL0OOg@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v7 00/13] trace-state: make the behaviour
 of "disable" consistent across all backends
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Llu=EDs?= <xscript@gmx.net>
Cc: qemu-devel@nongnu.org, chouteau@adacore.com

On Thu, Aug 25, 2011 at 8:17 PM, Llu=EDs <xscript@gmx.net> wrote:
> This patch defines the "disable" trace event state to always use the "nop=
"
> backend.
>
> As a side-effect, all events are now enabled (without "disable") by defau=
lt, as
> all backends (except "stderr") have programmatic support for dynamically
> (de)activating each trace event.
>
> In order to make this true, the "simple" backend now has a "-trace
> events=3D<file>" argument to let the user select which events must be ena=
bled from
> the very beginning.
>
> NOTES:
> * Parsing of -trace arguments is not done in the OS-specific frontends.
>
> Signed-off-by: Llu=EDs Vilanova <vilanova@ac.upc.edu>

I have posted a few comments and build-tested the simple, stderr, and
dtrace backends.  This is looking good, just a few small fixes.

Stefan