From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:59822) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R8pdV-0000Kg-8V for qemu-devel@nongnu.org; Wed, 28 Sep 2011 04:37:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R8pdR-0007rg-5E for qemu-devel@nongnu.org; Wed, 28 Sep 2011 04:37:01 -0400 Received: from mail-yi0-f45.google.com ([209.85.218.45]:60118) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R8pdR-0007rY-2N for qemu-devel@nongnu.org; Wed, 28 Sep 2011 04:36:57 -0400 Received: by yib2 with SMTP id 2so7849842yib.4 for ; Wed, 28 Sep 2011 01:36:56 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1317139327.12988.2.camel@d941e-10> References: <1317139327.12988.2.camel@d941e-10> Date: Wed, 28 Sep 2011 09:36:56 +0100 Message-ID: From: Stefan Hajnoczi Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Move filedescriptor parsing code from net.c into qemu_parse_fd() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Berger Cc: "qemu-devel@nongnu.org" , mst@redhat.com On Tue, Sep 27, 2011 at 5:02 PM, Stefan Berger wrote: > Move the parsing of a filedescriptor into a common function qemu_parse_fd= (). > Have the code in net.c call this function. > > Signed-off-by: Stefan Berger > > --- > =A0net.c =A0 =A0 =A0 | =A0 =A08 ++------ > =A0qemu-char.c | =A0 12 ++++++++++++ > =A0qemu-char.h | =A0 =A02 ++ > =A03 files changed, 16 insertions(+), 6 deletions(-) Seems fine but what does this have to do with qemu-char.h? Can this be a much more generic function, maybe even cutils.c? Stefan