qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	"Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [PATCH 2/2] qemu-option-trace.rst.inc: Don't use option:: markup
Date: Mon, 2 Nov 2020 11:22:33 +0000	[thread overview]
Message-ID: <CAJSP0QXd0YF=kVL41oMSTPRbRe5YC8Tt+VLAvwvuVVtrWr+dYA@mail.gmail.com> (raw)
In-Reply-To: <20201030174700.7204-3-peter.maydell@linaro.org>

On Fri, Oct 30, 2020 at 5:48 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> Sphinx 3.2 is pickier than earlier versions about the option:: markup,
> and complains about our usage in qemu-option-trace.rst:
>
> ../../docs/qemu-option-trace.rst.inc:4:Malformed option description
>   '[enable=]PATTERN', should look like "opt", "-opt args", "--opt args",
>   "/opt args" or "+opt args"
>
> In this file, we're really trying to document the different parts of
> the top-level --trace option, which qemu-nbd.rst and qemu-img.rst
> have already introduced with an option:: markup.  So it's not right
> to use option:: here anyway.  Switch to a different markup
> (definition lists) which gives about the same formatted output.
>
> (Unlike option::, this markup doesn't produce index entries; but
> at the moment we don't do anything much with indexes anyway, and
> in any case I think it doesn't make much sense to have individual
> index entries for the sub-parts of the --trace option.)
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  docs/qemu-option-trace.rst.inc | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Tested-by: Stefan Hajnoczi <stefanha@redhat.com>


  parent reply	other threads:[~2020-11-02 11:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-30 17:46 [PATCH 0/2] docs: Fix building with Sphinx 3.2 Peter Maydell
2020-10-30 17:46 ` [PATCH 1/2] scripts/kerneldoc: For Sphinx 3 use c:macro for macros with arguments Peter Maydell
2020-10-30 17:49   ` Daniel P. Berrangé
2020-11-02 11:24   ` Stefan Hajnoczi
2020-10-30 17:47 ` [PATCH 2/2] qemu-option-trace.rst.inc: Don't use option:: markup Peter Maydell
2020-10-30 17:48   ` Daniel P. Berrangé
2020-11-02 11:22   ` Stefan Hajnoczi [this message]
2020-10-30 18:20 ` [PATCH 0/2] docs: Fix building with Sphinx 3.2 Paolo Bonzini
2020-10-30 19:12   ` Peter Maydell
2020-10-30 20:02     ` Peter Maydell
2020-10-31 14:58       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJSP0QXd0YF=kVL41oMSTPRbRe5YC8Tt+VLAvwvuVVtrWr+dYA@mail.gmail.com' \
    --to=stefanha@gmail.com \
    --cc=berrange@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).