From: Stefan Hajnoczi <stefanha@gmail.com>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] xtensa_lx60: add missing #include "blockdev.h"
Date: Fri, 8 Jun 2012 11:08:40 +0100 [thread overview]
Message-ID: <CAJSP0QXdGwv6yiJ11R0apVkYRPUesC0VGtkVLiXphBFTfN_8BA@mail.gmail.com> (raw)
In-Reply-To: <1339149034-10163-1-git-send-email-jcmvbkbc@gmail.com>
On Fri, Jun 8, 2012 at 10:50 AM, Max Filippov <jcmvbkbc@gmail.com> wrote:
> This should fix the following build failure:
>
> /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c: In function 'lx_init':
> /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c:212: warning: implicit declaration of function 'drive_get'
> /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c:212: warning: nested extern declaration of 'drive_get'
> /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c:212: error: 'IF_PFLASH' undeclared (first use in this function)
> /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c:212: error: (Each undeclared identifier is reported only once
> /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c:212: error: for each function it appears in.)
> /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c:216: error: dereferencing pointer to incomplete type
>
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
> hw/xtensa_lx60.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
next prev parent reply other threads:[~2012-06-08 10:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 9:50 [Qemu-devel] [PATCH] xtensa_lx60: add missing #include "blockdev.h" Max Filippov
2012-06-08 10:08 ` Stefan Hajnoczi [this message]
2012-06-08 10:43 ` Stefan Weil
2012-06-08 10:57 ` Stefan Hajnoczi
2012-06-08 12:05 ` Stefan Weil
2012-06-08 12:43 ` Stefan Hajnoczi
2012-06-08 13:01 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJSP0QXdGwv6yiJ11R0apVkYRPUesC0VGtkVLiXphBFTfN_8BA@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=jcmvbkbc@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).