From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:41496)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QyjhR-0007VY-7A
	for qemu-devel@nongnu.org; Wed, 31 Aug 2011 08:15:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QyjhQ-0003vX-4B
	for qemu-devel@nongnu.org; Wed, 31 Aug 2011 08:15:21 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:52662)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QyjhP-0003vQ-UN
	for qemu-devel@nongnu.org; Wed, 31 Aug 2011 08:15:20 -0400
Received: by ywf9 with SMTP id 9so553262ywf.4
	for <qemu-devel@nongnu.org>; Wed, 31 Aug 2011 05:15:19 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20110825191750.1413.79427.stgit@ginnungagap.bsc.es>
References: <20110825191731.1413.26838.stgit@ginnungagap.bsc.es>
	<20110825191750.1413.79427.stgit@ginnungagap.bsc.es>
Date: Wed, 31 Aug 2011 13:15:19 +0100
Message-ID: <CAJSP0QXeahR_=gS6rPj43Z6YSDkot3N1K4HrDbeogQ7ZX19eqA@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v7 03/13] trace: [make] replace 'ifeq' with
	values in CONFIG_TRACE_*
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Llu=EDs?= <xscript@gmx.net>
Cc: qemu-devel@nongnu.org, chouteau@adacore.com

On Thu, Aug 25, 2011 at 8:17 PM, Llu=EDs <xscript@gmx.net> wrote:
> Signed-off-by: Llu=EDs Vilanova <vilanova@ac.upc.edu>
> ---
> =A0Makefile.objs | =A0 12 +++++-------
> =A01 files changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/Makefile.objs b/Makefile.objs
> index 44d7238..aaf6542 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -374,16 +374,14 @@ endif
>
> =A0simpletrace.o: simpletrace.c $(GENERATED_HEADERS)
>
> -ifeq ($(TRACE_BACKEND),dtrace)
> -trace-obj-y =3D trace-dtrace.o
> -else
> +trace-obj-$(CONFIG_TRACE_SYSTEMTAP) +=3D trace-dtrace.o
> +ifneq ($(TRACE_BACKEND),dtrace)

ifeq ($(TRACE_BACKEND),dtrace) is not equivalent to ifeq
($(CONFIG_TRACE_SYSTEMTAP),y).

There are 3 cases here:
1. The backend is not DTrace-like (e.g. stderr, simple, ust).
2. The backend is SystemTap (i.e. Fedora and Red Hat builds).
3. The backend is DTrace-like (i.e. Illumos real DTrace)

For most of the build 2 & 3 should be treated the same.  The only case
where we care about SystemTap specifically is when building .stp
files.

Therefore we need to introduce a CONFIG_TRACE_DTRACE in ./configure
and use that instead of CONFIG_TRACE_SYSTEMTAP here.  If we were to
use CONFIG_TRACE_SYSTEMTAP here then Illumos host builds will not be
able to use real DTrace.

Stefan