From: Haibo Xu <haibo.xu@linaro.org>
To: Andrew Jones <drjones@redhat.com>
Cc: philmd@redhat.com, qemu-arm@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH v2 11/12] target/arm/kvm: spe: Enable userspace irqchip support.
Date: Wed, 9 Sep 2020 11:12:06 +0800 [thread overview]
Message-ID: <CAJc+Z1EoJH3KXE65LESOU_ZRcn9zdY8hbTsye8ZaM+e==s103g@mail.gmail.com> (raw)
In-Reply-To: <20200908113458.2fdhbs7lpw63fvnv@kamzik.brq.redhat.com>
On Tue, 8 Sep 2020 at 19:35, Andrew Jones <drjones@redhat.com> wrote:
>
> On Tue, Sep 08, 2020 at 08:13:29AM +0000, Haibo Xu wrote:
> > Since the current kernel patches haven't enabled the
> > userspace irqchip support, this patch is not verified yet!
> >
> > Signed-off-by: Haibo Xu <haibo.xu@linaro.org>
> > ---
> > linux-headers/linux/kvm.h | 1 +
> > target/arm/kvm.c | 5 +++++
> > 2 files changed, 6 insertions(+)
> >
> > diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h
> > index 8840cbb01c..35ef0ae842 100644
> > --- a/linux-headers/linux/kvm.h
> > +++ b/linux-headers/linux/kvm.h
> > @@ -1672,6 +1672,7 @@ struct kvm_assigned_msix_entry {
> > #define KVM_ARM_DEV_EL1_VTIMER (1 << 0)
> > #define KVM_ARM_DEV_EL1_PTIMER (1 << 1)
> > #define KVM_ARM_DEV_PMU (1 << 2)
> > +#define KVM_ARM_DEV_SPE (1 << 3)
>
> kernel header changes should be separate patches
>
Will move this line to patch 01 in v3.
Thanks,
Haibo
> >
> > struct kvm_hyperv_eventfd {
> > __u32 conn_id;
> > diff --git a/target/arm/kvm.c b/target/arm/kvm.c
> > index 58f991e890..7950ff1d83 100644
> > --- a/target/arm/kvm.c
> > +++ b/target/arm/kvm.c
> > @@ -820,6 +820,11 @@ MemTxAttrs kvm_arch_post_run(CPUState *cs, struct kvm_run *run)
> > switched_level &= ~KVM_ARM_DEV_PMU;
> > }
> >
> > + if (switched_level & KVM_ARM_DEV_SPE) {
> > + qemu_set_irq(cpu->spe_interrupt,
> > + !!(run->s.regs.device_irq_level & KVM_ARM_DEV_SPE));
> > + switched_level &= ~KVM_ARM_DEV_SPE;
> > + }
> > if (switched_level) {
> > qemu_log_mask(LOG_UNIMP, "%s: unhandled in-kernel device IRQ %x\n",
> > __func__, switched_level);
> > --
> > 2.17.1
> >
>
> Otherwise
>
> Reviewed-by: Andrew Jones <drjones@redhat.com>
>
next prev parent reply other threads:[~2020-09-09 3:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 8:13 [PATCH v2 00/12] target/arm: Add vSPE support to KVM guest Haibo Xu
2020-09-08 8:13 ` [PATCH v2 01/12] update Linux headers with new vSPE macros Haibo Xu
2020-09-08 8:13 ` [PATCH v2 02/12] target/arm/kvm: spe: Add helper to detect SPE when using KVM Haibo Xu
2020-09-08 10:43 ` Andrew Jones
2020-09-08 8:13 ` [PATCH v2 03/12] target/arm/cpu: spe: Add an option to turn on/off vSPE support Haibo Xu
2020-09-08 10:51 ` Andrew Jones
2020-09-08 8:13 ` [PATCH v2 04/12] target/arm: spe: Only enable SPE from 5.2 compat machines Haibo Xu
2020-09-08 10:52 ` Andrew Jones
2020-09-08 8:13 ` [PATCH v2 05/12] target/arm/kvm: spe: Unify device attr operation helper Haibo Xu
2020-09-08 10:56 ` Andrew Jones
2020-09-09 2:39 ` Haibo Xu
2020-09-08 8:13 ` [PATCH v2 06/12] target/arm/kvm: spe: Add device init and set_irq operations Haibo Xu
2020-09-08 10:58 ` Andrew Jones
2020-09-08 8:13 ` [PATCH v2 07/12] hw/arm/virt: Move post cpu realize check into its own function Haibo Xu
2020-09-08 11:03 ` Andrew Jones
2020-09-09 6:54 ` Haibo Xu
2020-09-08 8:13 ` [PATCH v2 08/12] hw/arm/virt: Move kvm pmu setup to virt_cpu_post_init Haibo Xu
2020-09-08 11:07 ` Andrew Jones
2020-09-08 8:13 ` [PATCH v2 09/12] hw/arm/virt: spe: Add SPE fdt binding for virt machine Haibo Xu
2020-09-08 11:16 ` Andrew Jones
2020-09-09 7:51 ` Haibo Xu
2020-09-09 9:34 ` Andrew Jones
2020-09-10 0:31 ` Haibo Xu
2020-09-08 8:13 ` [PATCH v2 10/12] target/arm/cpu: spe: Enable spe to work with host cpu Haibo Xu
2020-09-08 11:32 ` Andrew Jones
2020-09-09 8:35 ` Haibo Xu
2020-09-08 8:13 ` [PATCH v2 11/12] target/arm/kvm: spe: Enable userspace irqchip support Haibo Xu
2020-09-08 11:34 ` Andrew Jones
2020-09-09 3:12 ` Haibo Xu [this message]
2020-09-08 8:13 ` [PATCH v2 12/12] target/arm: spe: Add corresponding doc and test Haibo Xu
2020-09-08 11:41 ` Andrew Jones
2020-09-09 3:19 ` Haibo Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJc+Z1EoJH3KXE65LESOU_ZRcn9zdY8hbTsye8ZaM+e==s103g@mail.gmail.com' \
--to=haibo.xu@linaro.org \
--cc=drjones@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).