From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18335C433E2 for ; Tue, 1 Sep 2020 02:27:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE06A2098B for ; Tue, 1 Sep 2020 02:27:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PW2UHMta" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE06A2098B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCw19-00085D-UB for qemu-devel@archiver.kernel.org; Mon, 31 Aug 2020 22:27:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCw0I-0007EQ-Mh for qemu-devel@nongnu.org; Mon, 31 Aug 2020 22:26:34 -0400 Received: from mail-il1-x144.google.com ([2607:f8b0:4864:20::144]:36066) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kCw0G-0003V0-I1 for qemu-devel@nongnu.org; Mon, 31 Aug 2020 22:26:34 -0400 Received: by mail-il1-x144.google.com with SMTP id p13so2983474ils.3 for ; Mon, 31 Aug 2020 19:26:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TgDfurcpkwV1piL8FLCPhFjRRWPG0mM3+/i3YH0OlkU=; b=PW2UHMtaPSgGXZN0I4nYhdblSycD3QurP+bRef9qjmxbor+z8httaXSj+Qqj6XFC8Q +ksFCXc0zjNmyL/SSEwc4dSrc2idPgHrIXwiSYpeoUbbvZTmtZKO+8Myc0dETo5D7yMB iD+me+pZaX+vu93cxz/IFTQP2OmEhrbuOfXCOCgGMI6ogwTUECkYwRj0mncJZbnK0Tdq iVY2A8sKWdx++gAp+7SF6oOXTUcLQL78UQ+5rm2HBip1fW1A88LflYx5rhk6UB8ySpWc gTmcSGeBb43vRIRxDCDktv8Ljd/kY8py85h4mwKNvMlZbasdDjHrI8A0aTCCwIzDmZ1D wcng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TgDfurcpkwV1piL8FLCPhFjRRWPG0mM3+/i3YH0OlkU=; b=funUKUAf+jVGj9978hYxH1XWhNHZZg0o2282AZdMRFf2DaHbNuVt0yAGbyT6MqRTHT 37DIh+ui6zTKrHh/l8j1VPlWjO9CxD7592Ll3daeAUINBMb86NVPwW/VL2Hk2R57cN1V N1pMnTIitSBQBOpGGBkxrPpzCSxlyO378cmLNTV+FEYvqgqg+nNVyFrkDizfIBrD2YwE H47jLt7Oly6HEiX77HbrXtWmhxamjVE1XvDbcc2El8PzAKvADIGnStSTxQdv6ND2kLXL 93esY/z46Mk86E5D9jh2Qz68oIlTGXjbpLWygRGvBKLHRjAZUBUtCgvqjb1CDY0lnkBv L5ng== X-Gm-Message-State: AOAM532bvgJ4f6iOe5mHqT2JevJciVTTgmZvyOFZxlW1HiL6eC0jrXu5 UpiajtjWcFIqMYD+FFSOYZ24IQZ6tKO4HtJmfJP7 X-Google-Smtp-Source: ABdhPJyUPHrOWVXLL/g0Ihn9kVQet0lDLHXMNTSMZuvWez+GrA4uDv09UA6wsWox3NrX/n9jrGbhDCFupYlRQF0HKkU= X-Received: by 2002:a92:9a15:: with SMTP id t21mr4071846ili.289.1598927191082; Mon, 31 Aug 2020 19:26:31 -0700 (PDT) MIME-Version: 1.0 References: <070de656-5550-62b7-faf9-8c4beec56531@redhat.com> In-Reply-To: <070de656-5550-62b7-faf9-8c4beec56531@redhat.com> From: Haibo Xu Date: Tue, 1 Sep 2020 10:26:19 +0800 Message-ID: Subject: Re: [PATCH 0/7] target/arm: Add vSPE support to KVM guest To: Auger Eric Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::144; envelope-from=haibo.xu@linaro.org; helo=mail-il1-x144.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Andrew Jones , qemu-devel@nongnu.org, qemu-arm@nongnu.org, Andrew Murray , philmd@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 31 Aug 2020 at 15:56, Auger Eric wrote: > > Hi Haibo, > > On 8/7/20 10:10 AM, Haibo Xu wrote: > > This series add support for SPE(Statistical Profiling Extension)[1] > > in KVM guest. It's based on Andrew Murray's kernel KVM patches V2[2], > > and has been tested to ensure that guest can use SPE with valid data. > > E.g. > > > > In host: > > $ ./qemu-system-aarch64 \ > > -cpu host -M virt,accel=kvm,gic-version=3 -nographic -m 2048M \ > > -kernel ./Image-new \ > > -initrd /boot/initrd.img-5.6.0-rc2+ \ > > -append "root=/dev/vda rw console=ttyAMA0" -nodefaults -serial stdio\ > > -drive if=none,file=./xenial.rootfs.ext4,id=hd0,format=raw \ > > -device virtio-blk-device,drive=hd0 \ > > > > In guest: > > $ perf record -e arm_spe/ts_enable=1,pa_enable=1,pct_enable=1/ \ > > dd if=/dev/zero of=/dev/null count=1000 > > $ perf report --dump-raw-trace > spe_buf.txt > > > > The spe_buf.txt should contain similar data as below: > > > > . ... ARM SPE data: size 135944 bytes > > . 00000000: b0 f4 d3 29 10 00 80 ff a0 PC 0xff80001029d3f4 el1 ns=1 > > . 00000009: 99 0b 00 LAT 11 ISSUE > > . 0000000c: 98 0d 00 LAT 13 TOT > > . 0000000f: 52 16 00 EV RETIRED L1D-ACCESS TLB-ACCESS > > . 00000012: 49 00 LD > > . 00000014: b2 d0 40 d8 70 00 00 ff 00 VA 0xff000070d840d0 > > . 0000001d: 9a 01 00 LAT 1 XLAT > > . 00000020: 00 00 00 PAD > > . 00000023: 71 a5 1f b3 20 14 00 00 00 TS 86447955877 > > . 0000002c: b0 7c f9 29 10 00 80 ff a0 PC 0xff80001029f97c el1 ns=1 > > . 00000035: 99 02 00 LAT 2 ISSUE > > . 00000038: 98 03 00 LAT 3 TOT > > . 0000003b: 52 02 00 EV RETIRED > > . 0000003e: 48 00 INSN-OTHER > > . 00000040: 00 00 00 PAD > > . 00000043: 71 ef 1f b3 20 14 00 00 00 TS 86447955951 > > . 0000004c: b0 f0 e9 29 10 00 80 ff a0 PC 0xff80001029e9f0 el1 ns=1 > > . 00000055: 99 02 00 LAT 2 ISSUE > > . 00000058: 98 03 00 LAT 3 TOT > > . 0000005b: 52 02 00 EV RETIRED > > > > If you want to disable the vSPE support, you can use the 'spe=off' cpu > > property: > > > > ./qemu-system-aarch64 \ > > -cpu host,spe=off -M virt,accel=kvm,gic-version=3 -nographic -m 2048M \ > > -kernel ./Image-new \ > > -initrd /boot/initrd.img-5.6.0-rc2+ \ > > -append "root=/dev/vda rw console=ttyAMA0" -nodefaults -serial stdio\ > > -drive if=none,file=./xenial.rootfs.ext4,id=hd0,format=raw \ > > -device virtio-blk-device,drive=hd0 \ > > > > Note: > > (1) Since the kernel patches are still under review, some of the macros > > in the header files may be changed after merging. We may need to > > update them accordingly. > to be more explicit one needs to replace on the kernel 5.5-rc2 based series > > -#define KVM_CAP_ARM_SPE_V1 179 > +#define KVM_CAP_ARM_SPE_V1 184 > > I got misleaded ;-) > > + Andrew in CC as he contributed the kernel part. > > For information, I have been working on a kvm unit test series for > testing SPE. I will send an RFC, most probably this week. At the moment > I still face some weirdness such as some unexpected Service state in the > syndrome register. Anyway I will share the existing code so that we can > discuss the issues. > > Are there any plans to respin the kernel series > > Thanks > > Eric > Hi Eric, Thanks for elaborating on the above macro definition! The next version of the kernel series are supposed to be sent out in mid-September, and it should not change so much except for some macro definitions. Regards, Haibo > > (2) These patches only add vSPE support in KVM mode, for TCG mode, I'm > > not sure whether we need to support it. > > (3) Just followed the 'pmu' property, we only allow this feature to be > > removed from CPUs which enable it by default. But since the SPE is > > an optional feature extension for Armv8.2, I think a better way may > > be to disable it by default, and only enable it when the host cpu > > do have the feature. > > > > [1]https://community.arm.com/developer/ip-products/processors/b/processors-ip-blog/ > > posts/statistical-profiling-extension-for-armv8-a > > [2]https://www.spinics.net/lists/arm-kernel/msg776228.html > > > > Haibo Xu (7): > > update Linux headers with new vSPE macros > > target/arm/kvm: spe: Add helper to detect SPE when using KVM > > target/arm/cpu: spe: Add an option to turn on/off vSPE support > > target/arm/kvm: spe: Unify device attr operatioin helper > > target/arm/kvm: spe: Add device init and set_irq operations > > hw/arm/virt: spe: Add SPE fdt binding for virt machine > > target/arm/cpu: spe: Enable spe to work with host cpu > > > > hw/arm/virt-acpi-build.c | 3 +++ > > hw/arm/virt.c | 42 ++++++++++++++++++++++++++++++ > > include/hw/acpi/acpi-defs.h | 1 + > > include/hw/arm/virt.h | 1 + > > linux-headers/asm-arm64/kvm.h | 4 +++ > > linux-headers/linux/kvm.h | 2 ++ > > target/arm/cpu.c | 34 +++++++++++++++++++++++++ > > target/arm/cpu.h | 5 ++++ > > target/arm/kvm.c | 11 ++++++++ > > target/arm/kvm64.c | 48 ++++++++++++++++++++++++++++++++--- > > target/arm/kvm_arm.h | 18 +++++++++++++ > > 11 files changed, 166 insertions(+), 3 deletions(-) > > >