From: Pranith Kumar <bobby.prani@gmail.com>
To: Laurent Vivier <laurent@vivier.eu>
Cc: Riku Voipio <riku.voipio@iki.fi>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
Allan Wirth <awirth@akamai.com>
Subject: Re: [Qemu-devel] [PATCH v2] linux-user: Add signal handling support for x86_64
Date: Sun, 26 Feb 2017 11:51:51 -0500 [thread overview]
Message-ID: <CAJhHMCAn=VYK9kCi-OA6oYXB6az6udBiByCPdeR0ws1ak4+Syw@mail.gmail.com> (raw)
In-Reply-To: <50cd1e34-deda-dc9b-2ce9-5c0cf09223cc@vivier.eu>
On Sun, Feb 26, 2017 at 7:29 AM, Laurent Vivier <laurent@vivier.eu> wrote:
>> @@ -6421,11 +6597,13 @@ static void handle_pending_signal(CPUArchState *cpu_env, int sig,
>> || defined(TARGET_NIOS2)
>> /* These targets do not have traditional signals. */
>> setup_rt_frame(sig, sa, &k->info, &target_old_set, cpu_env);
>> -#else
>> +#elif !defined(TARGET_X86_64)
>> if (sa->sa_flags & TARGET_SA_SIGINFO)
>> setup_rt_frame(sig, sa, &k->info, &target_old_set, cpu_env);
>> else
>> setup_frame(sig, sa, &target_old_set, cpu_env);
>> +#else
>> + setup_rt_frame(sig, sa, &k->info, &target_old_set, cpu_env);
>> #endif
>
> You should just add the "defined(TARGET_X86_64)" on the "#if".
>
OK, I'll send a v3. Thanks!
--
Pranith
prev parent reply other threads:[~2017-02-26 16:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-25 23:04 [Qemu-devel] [PATCH v2] linux-user: Add signal handling support for x86_64 Pranith Kumar
2017-02-26 12:29 ` Laurent Vivier
2017-02-26 12:39 ` Peter Maydell
2017-02-26 13:04 ` Laurent Vivier
2017-02-26 16:51 ` Pranith Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJhHMCAn=VYK9kCi-OA6oYXB6az6udBiByCPdeR0ws1ak4+Syw@mail.gmail.com' \
--to=bobby.prani@gmail.com \
--cc=awirth@akamai.com \
--cc=ehabkost@redhat.com \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).