From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37097)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bobby.prani@gmail.com>) id 1bFQ4n-0002DP-Iv
	for qemu-devel@nongnu.org; Tue, 21 Jun 2016 14:07:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bobby.prani@gmail.com>) id 1bFQ4m-0005mu-KH
	for qemu-devel@nongnu.org; Tue, 21 Jun 2016 14:07:05 -0400
Received: from mail-io0-x231.google.com ([2607:f8b0:4001:c06::231]:33551)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bobby.prani@gmail.com>) id 1bFQ4m-0005mk-FN
	for qemu-devel@nongnu.org; Tue, 21 Jun 2016 14:07:04 -0400
Received: by mail-io0-x231.google.com with SMTP id t74so23211799ioi.0
	for <qemu-devel@nongnu.org>; Tue, 21 Jun 2016 11:07:04 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <871t3qshmy.fsf@linaro.org>
References: <CAJhHMCB-jxvJK4EZvgcR6XWPRSDVUu0SknDV9isFkrdCW_Ydyg@mail.gmail.com>
	<871t3qshmy.fsf@linaro.org>
From: Pranith Kumar <bobby.prani@gmail.com>
Date: Tue, 21 Jun 2016 14:06:34 -0400
Message-ID: <CAJhHMCBVBQML-Y0anRgjnusbV-Q2eiwLm6TxMpSPNY=AsLBLGQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC v3 PATCH 01/14] Introduce TCGOpcode for
 memory barrier
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>
Cc: Sergey Fedorov <serge.fdrv@gmail.com>, Richard Henderson <rth@twiddle.net>, "open list:All patches CC here" <qemu-devel@nongnu.org>

On Tue, Jun 21, 2016 at 11:09 AM, Alex Benn=C3=A9e <alex.bennee@linaro.org>=
 wrote:
>>>
>>>> +    TCG_BAR_SC      =3D 128,
>>>
>>> How's that different from TCG_MO_ALL?
>>
>> TCG_BAR_* tells us what ordering is enforced. TCG_MO_* tells what on
>> what operations the ordering is to be enforced.
>
> This would be worthwhile in the comments. I'm confused by the fact we
> have two sets of enums that are going to be merged when building TCGOp
> parameters.

OK, I will add these comments with the details.

--=20
Pranith