From: Pranith Kumar <bobby.prani+qemu@gmail.com>
To: Michal Privoznik <mprivozn@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
Veronia Bahaa <veroniabahaa@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2] tests: Fix broken tcg test compilation
Date: Fri, 2 Sep 2016 08:04:32 -0400 [thread overview]
Message-ID: <CAJhHMCCuzg7aj018+tH6Qq75eJDePh6qzNuo6Hjcjaae3qWG_Q@mail.gmail.com> (raw)
In-Reply-To: <aee4e0cc17d97b27e57b5dc656d87eb4c12f9a44.1472816827.git.mprivozn@redhat.com>
Hi Michal,
On Fri, Sep 2, 2016 at 7:49 AM, Michal Privoznik <mprivozn@redhat.com> wrote:
> The first build error to be seen is that linux-test.c fails to
> include cutils.h:
>
> linux-test.c:42:25: fatal error: qemu/cutils.h: No such file or directory
>
> This is because toplevel include/ dir is not put onto compiler's
> command line. After that:
>
> qemu.git/include/qemu/cutils.h:171:1: error: unknown type name ‘bool’
>
> So we need to include "qemu/osdep.h" which will define bool type
> for us. However, osdep.h eventually includes glib.h from system,
> therefore we need to put GLIB_CFLAGS onto compiler's command line
> too.
>
> Lastly, getrusage is used in linux-test.c. This function and a
> struct it uses are defined in sys/resource.h:
>
> linux-test.c:247:5: warning: implicit declaration of function ‘getrusage’
>
I recently posted a patch series cleaning up tests/tcg. While doing
that I fixed the build issues I came across.
Please see: https://www.mail-archive.com/qemu-devel@nongnu.org/msg393764.html
Thanks,
--
Pranith
prev parent reply other threads:[~2016-09-02 12:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 11:49 [Qemu-devel] [PATCH v2] tests: Fix broken tcg test compilation Michal Privoznik
2016-09-02 11:56 ` Peter Maydell
2016-09-02 12:04 ` Pranith Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJhHMCCuzg7aj018+tH6Qq75eJDePh6qzNuo6Hjcjaae3qWG_Q@mail.gmail.com \
--to=bobby.prani+qemu@gmail.com \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=veroniabahaa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).