From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1tCW-0005xp-Iu for qemu-devel@nongnu.org; Sun, 15 May 2016 06:23:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b1tCU-0000N6-G2 for qemu-devel@nongnu.org; Sun, 15 May 2016 06:23:07 -0400 Received: from mail-vk0-x242.google.com ([2607:f8b0:400c:c05::242]:36703) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1tCU-0000Mz-B3 for qemu-devel@nongnu.org; Sun, 15 May 2016 06:23:06 -0400 Received: by mail-vk0-x242.google.com with SMTP id c189so17293149vkb.3 for ; Sun, 15 May 2016 03:23:06 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1463196873-17737-7-git-send-email-cota@braap.org> References: <1463196873-17737-1-git-send-email-cota@braap.org> <1463196873-17737-7-git-send-email-cota@braap.org> From: Pranith Kumar Date: Sun, 15 May 2016 06:22:36 -0400 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v5 06/18] atomics: add atomic_read_acquire and atomic_set_release List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Emilio G. Cota" Cc: QEMU Developers , MTTCG Devel , =?UTF-8?B?QWxleCBCZW5uw6ll?= , Paolo Bonzini , Peter Crosthwaite , Richard Henderson , Sergey Fedorov Hi Emilio, On Fri, May 13, 2016 at 11:34 PM, Emilio G. Cota wrote: > When __atomic is not available, we use full memory barriers instead > of smp/wmb, since acquire/release barriers apply to all memory > operations and not just to loads/stores, respectively. > If it is not too late can we rename this to atomic_load_acquire()/atomic_store_release() like in the linux kernel? Looks good either way. Reviewed-by: Pranith Kumar -- Pranith