From: Pranith Kumar <bobby.prani@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Eric Blake <eblake@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
John Snow <jsnow@redhat.com>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
Fam Zheng <famz@redhat.com>, Stefan Weil <sw@weilnetz.de>,
Stefan Hajnoczi <stefanha@gmail.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] Update README to accomodate markdown format
Date: Wed, 20 Jul 2016 18:15:14 -0400 [thread overview]
Message-ID: <CAJhHMCDjiggAubPBmPNuL3zupoAyPUf2cgRnWboJscU924cMBg@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA8dUxcZZrjhC5BVZ0VjoMXdWHuWM5hhcdh4CfeL0VCZYg@mail.gmail.com>
On Wed, Jul 20, 2016 at 6:07 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 20 July 2016 at 22:33, Pranith Kumar <bobby.prani@gmail.com> wrote:
>> Hmm, the original README did not have an explicit new line at end of
>> file.
>
> Yes it did:
> $ git show 70f87e0f0a:README | tail -c 1 | od -An -a
> nl
>
OK.
The v2 version of the patch I sent earlier has this fixed. I thought
that Eric was commenting on that version but he was commenting on v1.
Thanks,
--
Pranith
prev parent reply other threads:[~2016-07-20 22:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 19:39 [Qemu-devel] [PATCH 0/3] Fix regression caused my moving README Pranith Kumar
2016-07-20 19:39 ` [Qemu-devel] [PATCH 1/3] Revert e4dfc5e8e("Move README to markdown") Pranith Kumar
2016-07-20 20:14 ` Stefan Weil
2016-07-20 19:39 ` [Qemu-devel] [PATCH 2/3] Create README.md as a symlink to README Pranith Kumar
2016-07-20 19:39 ` [Qemu-devel] [PATCH 3/3] Update README to accomodate markdown format Pranith Kumar
2016-07-20 20:10 ` Stefan Weil
2016-07-20 20:21 ` Pranith Kumar
2016-07-20 21:29 ` Eric Blake
2016-07-20 21:33 ` Pranith Kumar
2016-07-20 21:41 ` Eric Blake
2016-07-20 22:07 ` Peter Maydell
2016-07-20 22:15 ` Pranith Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJhHMCDjiggAubPBmPNuL3zupoAyPUf2cgRnWboJscU924cMBg@mail.gmail.com \
--to=bobby.prani@gmail.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).