From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39266)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <qemulist@gmail.com>) id 1V3zmg-0002m9-1r
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 22:35:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <qemulist@gmail.com>) id 1V3zme-0006wJ-2b
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 22:35:34 -0400
Received: from mail-la0-x230.google.com ([2a00:1450:4010:c03::230]:51890)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <qemulist@gmail.com>) id 1V3zmd-0006vm-OZ
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 22:35:31 -0400
Received: by mail-la0-f48.google.com with SMTP id hi8so4507768lab.21
	for <qemu-devel@nongnu.org>; Mon, 29 Jul 2013 19:35:30 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <51F66A1D.2020409@redhat.com>
References: <1375067768-11342-1-git-send-email-pingfank@linux.vnet.ibm.com>
	<1375067768-11342-5-git-send-email-pingfank@linux.vnet.ibm.com>
	<51F60C64.30908@redhat.com>
	<CAJnKYQn7NhP-i3oNNE3e14MgYMS2HmR3OU-th3XYWFxRMyVZHw@mail.gmail.com>
	<51F66A1D.2020409@redhat.com>
From: liu ping fan <qemulist@gmail.com>
Date: Tue, 30 Jul 2013 10:35:10 +0800
Message-ID: <CAJnKYQ=g8KyidYj2sB2reaDrkw97Gvi4ySf2qfvdSeGgmL-9Pw@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [RFC v2 4/5] timer: associate three timerlists
	with AioContext
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Alex Bligh <alex@alex.org.uk>, Anthony Liguori <anthony@codemonkey.ws>

On Mon, Jul 29, 2013 at 9:11 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 29/07/2013 10:20, liu ping fan ha scritto:
>>> > Another issue is that deadline computation is not using the AioContext's
>>> > timer lists.
>>> >
>> Sorry, can not catch the meaning. When AioContext has its own timer
>> lists, it will have its own deadline(for ppoll timeout). So the
>> computation should be based on AioContext's timer lists, right?
>
> Associating the main loop's timer lists to other AioContexts is really

Main loop's timers will only be associated with the qemu_aio_context,
not with other AioContext. (When creating timer, we have bound it with
a specified AioContext, so it will only run on that AioContext)

> really wrong...  It is _already_ wrong to run timers in the main
> AioContext's aio_poll (because timers may not be ready to run from an

Sorry, but except that timer cb will call aio_poll, any other reason ?
> arbitrary aio_poll), it is even worse to run them in other threads
> without taking the BQL.
>
Can be fixed by some method to sync  the dedicated thread with vcpus?

> What exactly is the purpose of this series?
>
Enable timers to run on the dedicated threads(using aio as the
mini-loop), currently for the following devices,
    virtio-blk-dataplane for throttling
    hpet for the best-effort resolution

Thanks and regards,
Pingfan
> Paolo