From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39220)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <qemulist@gmail.com>) id 1ULTSn-0004cq-VY
	for qemu-devel@nongnu.org; Fri, 29 Mar 2013 03:11:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <qemulist@gmail.com>) id 1ULTSl-00049W-Vk
	for qemu-devel@nongnu.org; Fri, 29 Mar 2013 03:11:01 -0400
Received: from mail-lb0-f177.google.com ([209.85.217.177]:36298)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <qemulist@gmail.com>) id 1ULTSl-000493-N9
	for qemu-devel@nongnu.org; Fri, 29 Mar 2013 03:10:59 -0400
Received: by mail-lb0-f177.google.com with SMTP id r10so105867lbi.22
	for <qemu-devel@nongnu.org>; Fri, 29 Mar 2013 00:10:58 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAFEAcA8n1EwEHYphBQojj_qRzbdHC53sgg0nZFtuqY9QXhm2-Q@mail.gmail.com>
References: <1364458107-5893-1-git-send-email-pingfank@linux.vnet.ibm.com>
	<CAFEAcA8n1EwEHYphBQojj_qRzbdHC53sgg0nZFtuqY9QXhm2-Q@mail.gmail.com>
From: liu ping fan <qemulist@gmail.com>
Date: Fri, 29 Mar 2013 15:10:38 +0800
Message-ID: <CAJnKYQkba6to+ojAyFuB7ED+AX3bxQZG3jjQdFgQNKpLJwmOYA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCH] memory: reverse the priority when commit
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Anthony Liguori <aliguori@us.ibm.com>, Liu Ping Fan <pingfank@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>

On Thu, Mar 28, 2013 at 10:44 PM, Peter Maydell
<peter.maydell@linaro.org> wrote:
> On 28 March 2013 08:08, Liu Ping Fan <pingfank@linux.vnet.ibm.com> wrote:
>> In theroy, the high priority should commit earlier, it is the same
>> reason as the sequence of "Lower = earlier (during add), later (during del)"
>
> Hi. Could you give a bit more detail about the reason for this
> change, please? Do any of our existing commit hooks currently
> care about the order in which they're called (ie is this fixing
> a bug), or is there some use case that would care in future?
>
> This change may well be right but it's not immediately obvious
> that begin/commit are a paired set in the same way as (say)
> add/del and log_start/log_stop, so more rationale would be
> helpful.
>
Each componet (core, kvm,vhost) should have different priority to see
the change of the memory layout, for they are async.  But oh, here
seems that I make a mistake, the sequence of commit has already make
high priority first.

Regards,
Pingfan
> thanks
> -- PMM
>