From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxRkE-0008JJ-Qq for qemu-devel@nongnu.org; Tue, 14 Feb 2012 18:25:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RxRkD-0008TL-2Q for qemu-devel@nongnu.org; Tue, 14 Feb 2012 18:25:10 -0500 Received: from mail-ww0-f53.google.com ([74.125.82.53]:43378) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RxRkC-0008Sf-UE for qemu-devel@nongnu.org; Tue, 14 Feb 2012 18:25:09 -0500 Received: by wgbdr12 with SMTP id dr12so418198wgb.10 for ; Tue, 14 Feb 2012 15:25:07 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1328841077-25133-1-git-send-email-meadori@codesourcery.com> References: <1328841077-25133-1-git-send-email-meadori@codesourcery.com> Date: Tue, 14 Feb 2012 17:25:07 -0600 Message-ID: From: Meador Inge Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 0/1] Allow the building of VirtFS to be disabled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, Meador Inge , aneesh.kumar@linux.vnet.ibm.com Ping... Any comments on the v3 patch? http://lists.nongnu.org/archive/html/qemu-devel/2012-02/msg01236.html On Thu, Feb 9, 2012 at 8:31 PM, Meador Inge wrot= e: > There have been reports [1, 2] where folks have had issues building > VirtFS and the virtio backend on older systems. =A0I personally saw > problems due to the use of features (struct statfs f_frsize field, > fdopendir, O_NOATIME) in this code that are not available on much older > Linux systems. =A0Given, the system I ran into this on is ancient (RH8 sy= sroot), > but I still need to build QEMU on it nonetheless. > > This patch adds a new configure option for disabling the building of > VirtFS all together. =A0Tested by building with and without --disable-vir= tfs > on older (RH8 sysroot) and newer systems (x64 Fedora 16). > > [1] http://lists.nongnu.org/archive/html/qemu-devel/2011-12/msg00171.html > [2] http://lists.nongnu.org/archive/html/qemu-devel/2012-02/msg00404.html > > * Changes from v2 > =A0- Use 'test "$foo" =3D yes && test "$bar" =3D yes' instead of > =A0 =A0'"$foo" =3D "yes" -a "$bar" =3D "yes"'. > * Changes from v1 > =A0- Simplify the configure logic and support the standard behavior > =A0 =A0of defaulting virtfs=3D"". =A0Changes suggested by Peter Maydell. > > Meador Inge (1): > =A0./configure: add option for disabling VirtFS > > =A0Makefile =A0| =A0 =A02 ++ > =A0configure | =A0 25 +++++++++++++++++++------ > =A02 files changed, 21 insertions(+), 6 deletions(-) > > -- > 1.7.7.6 > > --=20 # Meador