From: Michael Rolnik <mrolnik@gmail.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH 07/26] target/avr: Mark some helpers noreturn
Date: Mon, 21 Jun 2021 08:39:50 +0300 [thread overview]
Message-ID: <CAK4993hWnOK1t2=cPsYLFYMv-MpeLMJOEafz-qCWK4u33jdo6Q@mail.gmail.com> (raw)
In-Reply-To: <20210621013439.1791385-8-richard.henderson@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]
Reviewed-by: Michael Rolnik <mrolnik@gmail.com>
On Mon, Jun 21, 2021 at 4:34 AM Richard Henderson <
richard.henderson@linaro.org> wrote:
> All of these helpers end with cpu_loop_exit.
>
> Cc: Michael Rolnik <mrolnik@gmail.com>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/avr/helper.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/target/avr/helper.h b/target/avr/helper.h
> index 8e1ae7fda0..4d02e648fa 100644
> --- a/target/avr/helper.h
> +++ b/target/avr/helper.h
> @@ -19,10 +19,10 @@
> */
>
> DEF_HELPER_1(wdr, void, env)
> -DEF_HELPER_1(debug, void, env)
> -DEF_HELPER_1(break, void, env)
> -DEF_HELPER_1(sleep, void, env)
> -DEF_HELPER_1(unsupported, void, env)
> +DEF_HELPER_1(debug, noreturn, env)
> +DEF_HELPER_1(break, noreturn, env)
> +DEF_HELPER_1(sleep, noreturn, env)
> +DEF_HELPER_1(unsupported, noreturn, env)
> DEF_HELPER_3(outb, void, env, i32, i32)
> DEF_HELPER_2(inb, tl, env, i32)
> DEF_HELPER_3(fullwr, void, env, i32, i32)
> --
> 2.25.1
>
>
--
Best Regards,
Michael Rolnik
[-- Attachment #2: Type: text/html, Size: 1739 bytes --]
next prev parent reply other threads:[~2021-06-21 5:42 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 1:34 [PATCH 00/26] accel/tcg: Introduce translator_use_goto_tb Richard Henderson
2021-06-21 1:34 ` [PATCH 01/26] " Richard Henderson
2021-06-21 6:24 ` Max Filippov
2021-06-21 12:50 ` Philippe Mathieu-Daudé
2021-06-21 13:47 ` Richard Henderson
2021-06-21 15:03 ` Philippe Mathieu-Daudé
2021-06-21 13:45 ` Luis Fernando Fujita Pires
2021-06-21 1:34 ` [PATCH 02/26] target/alpha: Remove use_exit_tb Richard Henderson
2021-06-21 1:34 ` [PATCH 03/26] target/alpha: Remove in_superpage Richard Henderson
2021-06-21 1:34 ` [PATCH 04/26] target/alpha: Use translator_use_goto_tb Richard Henderson
2021-06-21 1:34 ` [PATCH 05/26] target/arm: " Richard Henderson
2021-06-21 10:20 ` Peter Maydell
2021-06-21 1:34 ` [PATCH 06/26] target/avr: " Richard Henderson
2021-06-21 1:34 ` [PATCH 07/26] target/avr: Mark some helpers noreturn Richard Henderson
2021-06-21 5:39 ` Michael Rolnik [this message]
2021-06-21 12:31 ` Philippe Mathieu-Daudé
2021-06-21 1:34 ` [PATCH 08/26] target/cris: Use translator_use_goto_tb Richard Henderson
2021-06-21 1:34 ` [PATCH 09/26] target/hppa: " Richard Henderson
2021-06-21 1:34 ` [PATCH 10/26] target/i386: " Richard Henderson
2021-06-21 1:34 ` [PATCH 11/26] target/m68k: " Richard Henderson
2021-06-21 7:35 ` Laurent Vivier
2021-06-21 1:34 ` [PATCH 12/26] target/microblaze: " Richard Henderson
2021-06-21 1:34 ` [PATCH 13/26] target/mips: " Richard Henderson
2021-06-21 1:34 ` [PATCH 14/26] target/mips: Fix missing else in gen_goto_tb Richard Henderson
2021-06-21 12:25 ` Philippe Mathieu-Daudé
2021-06-21 1:34 ` [PATCH 15/26] target/nios2: Use translator_use_goto_tb Richard Henderson
2021-06-21 1:34 ` [PATCH 16/26] target/openrisc: " Richard Henderson
2021-06-21 1:34 ` [PATCH 17/26] target/ppc: " Richard Henderson
2021-06-21 13:45 ` Luis Fernando Fujita Pires
2021-06-21 1:34 ` [PATCH 18/26] target/riscv: " Richard Henderson
2021-06-21 22:22 ` Alistair Francis
2021-06-21 1:34 ` [PATCH 19/26] target/rx: " Richard Henderson
2021-06-21 1:34 ` [PATCH 20/26] target/s390x: " Richard Henderson
2021-06-21 1:34 ` [PATCH 21/26] target/s390x: Remove use_exit_tb Richard Henderson
2021-06-21 1:34 ` [PATCH 22/26] target/sh4: Use translator_use_goto_tb Richard Henderson
2021-06-21 1:34 ` [PATCH 23/26] target/sparc: " Richard Henderson
2021-06-21 9:09 ` Mark Cave-Ayland
2021-06-21 1:34 ` [PATCH 24/26] target/tricore: " Richard Henderson
2021-06-21 14:27 ` Bastian Koppelmann
2021-06-21 1:34 ` [PATCH 25/26] target/tricore: Use tcg_gen_lookup_and_goto_ptr Richard Henderson
2021-06-21 14:32 ` Bastian Koppelmann
2021-06-21 1:34 ` [PATCH 26/26] target/xtensa: Use translator_use_goto_tb Richard Henderson
2021-06-21 6:24 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK4993hWnOK1t2=cPsYLFYMv-MpeLMJOEafz-qCWK4u33jdo6Q@mail.gmail.com' \
--to=mrolnik@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).