From: Michael Rolnik <mrolnik@gmail.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Eduardo Habkost <eduardo@habkost.net>,
qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH] hw/avr: Realize AVRCPU qdev object using qdev_realize()
Date: Mon, 6 Dec 2021 10:49:29 +0200 [thread overview]
Message-ID: <CAK4993ioRGczZMKbOvmqyVThz+th8-Jx8Koe1qhDFMfcpt1DRw@mail.gmail.com> (raw)
In-Reply-To: <20211205224109.322152-1-f4bug@amsat.org>
[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]
Reviewed-by: Michael Rolnik <mrolnik@gmail.com>
On Mon, Dec 6, 2021 at 12:41 AM Philippe Mathieu-Daudé <f4bug@amsat.org>
wrote:
> TYPE_AVR_CPU inherits TYPE_CPU, which itself inherits TYPE_DEVICE.
> TYPE_DEVICE instances are realized using qdev_realize(), we don't
> need to access QOM internal values.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/avr/atmega.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/avr/atmega.c b/hw/avr/atmega.c
> index 0608e2d475e..a34803e6427 100644
> --- a/hw/avr/atmega.c
> +++ b/hw/avr/atmega.c
> @@ -233,7 +233,7 @@ static void atmega_realize(DeviceState *dev, Error
> **errp)
>
> /* CPU */
> object_initialize_child(OBJECT(dev), "cpu", &s->cpu, mc->cpu_type);
> - object_property_set_bool(OBJECT(&s->cpu), "realized", true,
> &error_abort);
> + qdev_realize(DEVICE(&s->cpu), NULL, &error_abort);
> cpudev = DEVICE(&s->cpu);
>
> /* SRAM */
> --
> 2.33.1
>
>
--
Best Regards,
Michael Rolnik
[-- Attachment #2: Type: text/html, Size: 1626 bytes --]
next prev parent reply other threads:[~2021-12-06 8:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-05 22:41 [PATCH] hw/avr: Realize AVRCPU qdev object using qdev_realize() Philippe Mathieu-Daudé
2021-12-06 8:49 ` Michael Rolnik [this message]
2021-12-15 10:25 ` Philippe Mathieu-Daudé
2021-12-17 9:43 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK4993ioRGczZMKbOvmqyVThz+th8-Jx8Koe1qhDFMfcpt1DRw@mail.gmail.com \
--to=mrolnik@gmail.com \
--cc=armbru@redhat.com \
--cc=eduardo@habkost.net \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).