From: Kuo-Jung Su <dantesu@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Igor Mitsyanko <i.mitsyanko@samsung.com>,
qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>,
Paul Brook <paul@codesourcery.com>,
Kuo-Jung Su <dantesu@faraday-tech.com>,
Andreas <afaerber@suse.de>,
fred konrad <fred.konrad@greensocs.com>
Subject: Re: [Qemu-devel] [PATCH v8 00/24] hw/arm: add Faraday A369 SoC platform support
Date: Mon, 18 Mar 2013 08:56:38 +0800 [thread overview]
Message-ID: <CAK65tU6_oBOQCVcTaZyvcbR4UvdboQ75pRvGOuj11Ffm08e5qA@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA9_JQ5N3=ZNudMUU0__t2ybFJDcFce-mpC=KGuABN9c_g@mail.gmail.com>
2013/3/15 Peter Maydell <peter.maydell@linaro.org>:
> On 15 March 2013 13:15, Kuo-Jung Su <dantesu@gmail.com> wrote:
>> default-configs/arm-softmmu.mak | 1 +
>> hw/Makefile.objs | 2 +
>> hw/arm/Makefile.objs | 21 ++
>> hw/arm/faraday.h | 61 ++++
>> hw/arm/faraday_a369.c | 174 ++++++++++
>> hw/arm/faraday_a369_kpd.c | 231 +++++++++++++
>> hw/arm/faraday_a369_scu.c | 182 ++++++++++
>> hw/arm/faraday_a369_soc.c | 342 +++++++++++++++++++
>> hw/arm/ftahbc020.c | 202 +++++++++++
>> hw/arm/ftapbbrg020.c | 468 ++++++++++++++++++++++++++
>> hw/arm/ftapbbrg020.h | 44 +++
>> hw/arm/ftddrii030.c | 183 ++++++++++
>> hw/arm/ftdmac020.c | 595 ++++++++++++++++++++++++++++++++
>> hw/arm/ftdmac020.h | 107 ++++++
>> hw/arm/ftgmac100.c | 708 +++++++++++++++++++++++++++++++++++++++
>> hw/arm/ftgmac100.h | 239 +++++++++++++
>> hw/arm/fti2c010.c | 212 ++++++++++++
>> hw/arm/fti2c010.h | 71 ++++
>> hw/arm/ftintc020.c | 302 +++++++++++++++++
>> hw/arm/ftintc020.h | 57 ++++
>> hw/arm/ftkbc010.h | 44 +++
>> hw/arm/ftlcdc200.c | 510 ++++++++++++++++++++++++++++
>> hw/arm/ftlcdc200.h | 112 +++++++
>> hw/arm/ftlcdc200_template.h | 439 ++++++++++++++++++++++++
>> hw/arm/ftmac110.c | 661 ++++++++++++++++++++++++++++++++++++
>> hw/arm/ftmac110.h | 168 ++++++++++
>> hw/arm/ftnandc021.c | 516 ++++++++++++++++++++++++++++
>> hw/arm/ftnandc021.h | 84 +++++
>> hw/arm/ftpwmtmr010.c | 258 ++++++++++++++
>> hw/arm/ftpwmtmr010.h | 31 ++
>> hw/arm/ftrtc011.c | 383 +++++++++++++++++++++
>> hw/arm/ftrtc011.h | 53 +++
>> hw/arm/ftsdc010.c | 354 ++++++++++++++++++++
>> hw/arm/ftsdc010.h | 90 +++++
>> hw/arm/ftspi020.c | 337 +++++++++++++++++++
>> hw/arm/ftspi020.h | 81 +++++
>> hw/arm/ftssp010.c | 494 +++++++++++++++++++++++++++
>> hw/arm/ftssp010.h | 98 ++++++
>> hw/arm/fttmr010.c | 445 ++++++++++++++++++++++++
>> hw/arm/fttmr010.h | 41 +++
>> hw/arm/fttsc010.c | 260 ++++++++++++++
>> hw/arm/fttsc010.h | 39 +++
>> hw/arm/ftwdt010.c | 209 ++++++++++++
>> hw/arm/ftwdt010.h | 35 ++
>
> I don't have time to do a full review right now, but a lot
> of these files are in the wrong place. If it looks like a
> device it doesn't belong in hw/arm (top level board models
> and things that directly reference the CPU only).
>
> -- PMM
Got it, thanks.
--
Best wishes,
Kuo-Jung Su
next prev parent reply other threads:[~2013-03-18 0:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 13:15 [Qemu-devel] [PATCH v8 00/24] hw/arm: add Faraday A369 SoC platform support Kuo-Jung Su
2013-03-15 13:15 ` [Qemu-devel] [PATCH v8 01/24] target-arm: add Faraday ARMv5TE processors support Kuo-Jung Su
2013-03-15 13:15 ` [Qemu-devel] [PATCH v8 02/24] hw/arm: add Faraday a369 SoC platform support Kuo-Jung Su
2013-03-15 13:15 ` [Qemu-devel] [PATCH v8 03/24] hw/arm: add FTINTC020 interrupt controller support Kuo-Jung Su
2013-03-15 13:15 ` [Qemu-devel] [PATCH v8 04/24] hw/arm: add FTAHBC020 AHB " Kuo-Jung Su
2013-03-15 13:15 ` [Qemu-devel] [PATCH v8 05/24] hw/arm: add FTDDRII030 DDRII " Kuo-Jung Su
2013-03-15 13:15 ` [Qemu-devel] [PATCH v8 06/24] hw/arm: add FTPWMTMR010 timer support Kuo-Jung Su
2013-03-15 13:15 ` [Qemu-devel] [PATCH v8 07/24] hw/arm: add FTWDT010 watchdog " Kuo-Jung Su
2013-03-15 13:15 ` [Qemu-devel] [PATCH v8 08/24] hw/arm: add FTRTC011 RTC " Kuo-Jung Su
2013-03-15 13:15 ` [Qemu-devel] [PATCH v8 09/24] tests: add QTest for FTRTC011 Kuo-Jung Su
2013-03-15 13:15 ` [Qemu-devel] [PATCH v8 10/24] hw/arm: add FTDMAC020 AHB DMA support Kuo-Jung Su
2013-03-15 13:15 ` [Qemu-devel] [PATCH v8 11/24] hw/arm: add FTAPBBRG020 APB " Kuo-Jung Su
2013-03-15 13:15 ` [Qemu-devel] [PATCH v8 12/24] hw/arm: add FTNANDC021 nand flash controller support Kuo-Jung Su
2013-03-15 13:15 ` [Qemu-devel] [PATCH v8 13/24] hw/arm: add FTI2C010 I2C " Kuo-Jung Su
2013-03-16 4:13 ` Peter Crosthwaite
2013-03-18 1:28 ` Kuo-Jung Su
2013-03-15 13:15 ` [Qemu-devel] [PATCH v8 14/24] hw: Add AudioCodecClass for wm87xx audio class abstration Kuo-Jung Su
2013-03-15 13:15 ` [Qemu-devel] [PATCH v8 15/24] hw: add WM8731 audio codec support Kuo-Jung Su
2013-03-15 13:15 ` [Qemu-devel] [PATCH v8 16/24] hw/arm: add FTSSP010 multi-function controller support Kuo-Jung Su
2013-03-15 13:15 ` [Qemu-devel] [PATCH v8 17/24] qemu/bitops.h: add the bit ordering reversal functions Kuo-Jung Su
2013-03-15 13:15 ` [Qemu-devel] [PATCH v8 18/24] hw/arm: add FTGMAC100 1Gbps ethernet support Kuo-Jung Su
2013-03-15 13:15 ` [Qemu-devel] [PATCH v8 19/24] hw/arm: add FTLCDC200 LCD controller support Kuo-Jung Su
2013-03-15 13:15 ` [Qemu-devel] [PATCH v8 20/24] hw/arm: add FTTSC010 touchscreen " Kuo-Jung Su
2013-03-15 13:15 ` [Qemu-devel] [PATCH v8 21/24] hw/arm: add FTSDC010 MMC/SD " Kuo-Jung Su
2013-03-15 13:15 ` [Qemu-devel] [PATCH v8 22/24] hw/arm: add FTMAC110 10/100Mbps ethernet support Kuo-Jung Su
2013-03-15 13:15 ` [Qemu-devel] [PATCH v8 23/24] hw/arm: add FTTMR010 timer support Kuo-Jung Su
2013-03-15 13:15 ` [Qemu-devel] [PATCH v8 24/24] hw/arm: add FTSPI020 SPI flash controller support Kuo-Jung Su
2013-03-15 13:47 ` [Qemu-devel] [PATCH v8 00/24] hw/arm: add Faraday A369 SoC platform support Peter Maydell
2013-03-18 0:56 ` Kuo-Jung Su [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-03-15 13:13 Kuo-Jung Su
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK65tU6_oBOQCVcTaZyvcbR4UvdboQ75pRvGOuj11Ffm08e5qA@mail.gmail.com \
--to=dantesu@gmail.com \
--cc=afaerber@suse.de \
--cc=blauwirbel@gmail.com \
--cc=dantesu@faraday-tech.com \
--cc=fred.konrad@greensocs.com \
--cc=i.mitsyanko@samsung.com \
--cc=paul@codesourcery.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).