From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DBC8D1A443 for ; Sat, 12 Oct 2024 07:40:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1szWj7-0004cE-NX; Sat, 12 Oct 2024 03:39:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szWj5-0004Xb-Gx for qemu-devel@nongnu.org; Sat, 12 Oct 2024 03:39:47 -0400 Received: from mail-oo1-xc36.google.com ([2607:f8b0:4864:20::c36]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1szWj3-0004ED-3N for qemu-devel@nongnu.org; Sat, 12 Oct 2024 03:39:47 -0400 Received: by mail-oo1-xc36.google.com with SMTP id 006d021491bc7-5e8038d4931so1618438eaf.2 for ; Sat, 12 Oct 2024 00:39:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smartx-com.20230601.gappssmtp.com; s=20230601; t=1728718782; x=1729323582; darn=nongnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TfUEplD38YviOYL4MDo7kAXbkr2eDZCWenj06SLfBkQ=; b=SroeBiFZ05KLkfFD+q/1YNlZtjNb+UDZ9/yvdTBePykoajRQpDXk2DCJXmmaUE8krD XATBSjOUYAJ82L5uEPzFgQG4YCCIRO30g46peOkH3p7UGH5vPHq/kdspo5+1HEIRTRPD IAN7ZZ1r9tzZsAQqyv2/KRuCbWjBuEF+T3om0G1K6cUZW8YjX4o/ruFj6aU7h6jN57jW 0wKo1IGGpndvN6Ta9vFlUkKeGq+9ObE8DtPmSBjbuLfcTGp6Nvhlmf8ecSyAQWaIE1zP K9n10E+s2yiSulv2CE7ncLTQugMUpa1JM81HcMDWO31RsVahlNkgSG7m11rqgzIu4jTF SJOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728718782; x=1729323582; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TfUEplD38YviOYL4MDo7kAXbkr2eDZCWenj06SLfBkQ=; b=dHPYMCnpbSaF200QlhdP0+N0ZXtWGckbtiwkXI3cWhIOYkcvDWByFppT0FKYjefzVt jMvaMCH3lCY9+E/VrosR+1UZmf36HcHH6WNxf0HNb8YoV0th+WWT72Y5KCOLvzLSA6zU Qsfs3hNs01DtoY6G7Sc0l4Wm7DxNuSsgbFPYwrqvqUapbCpLAWE1HYdr/TosNmUDNcd+ 6Nsgmla5907dqzNJnMspGMfcXxQTiY8mbCMuCx94YCvU1TAXAemEajRHGgOa+RnssfGp zZMKtCQYw4ibWRh/+k1zglKNnTIhFUAePwDaegbfFskyawRQQtWbqkYNRn/d5uMnRGzp W2mw== X-Forwarded-Encrypted: i=1; AJvYcCX1D1s3837bsmtFrOfw846M8hSfTtjE+V4DtUM+p88C4eKt9Kapn99BWZcVfeeWzST/5YyY1KDRFnwX@nongnu.org X-Gm-Message-State: AOJu0YwzRMpBVWcPkpgBEkzFA5XIP9HPjie+2IxrTNu5N8F8YQbSVQ2l tMfeajk6lhKAfUqPu2O6u00j1GO2t5uztUOTjnVV5bcBbqT1lbdyFoxc5qCF6oBKQ9crfcIi+oz TEBEh8AhcfUZQqpPCI/HKisVLH3PxP3fuocVFKA== X-Google-Smtp-Source: AGHT+IEO32QF6PfmZgrwKU0DLMA+G3JNy5LzNnLZyv7BzbFjCOUfsN7qPAL06dhAR2BUlxTc/g9SXB2ciTU+zIIzCNE= X-Received: by 2002:a05:6870:79e:b0:267:dfce:95eb with SMTP id 586e51a60fabf-2886dce9beamr2926919fac.5.1728718781660; Sat, 12 Oct 2024 00:39:41 -0700 (PDT) MIME-Version: 1.0 References: <20241011153652.517440-1-peterx@redhat.com> <87v7xyr1jz.fsf@suse.de> In-Reply-To: <87v7xyr1jz.fsf@suse.de> From: Yong Huang Date: Sat, 12 Oct 2024 15:39:25 +0800 Message-ID: Subject: Re: [PATCH] migration: Put thread names together with macros To: Fabiano Rosas Cc: Peter Xu , qemu-devel@nongnu.org, Hailiang Zhang Content-Type: multipart/alternative; boundary="000000000000e5d655062442b43a" Received-SPF: pass client-ip=2607:f8b0:4864:20::c36; envelope-from=yong.huang@smartx.com; helo=mail-oo1-xc36.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --000000000000e5d655062442b43a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Oct 12, 2024 at 1:29=E2=80=AFAM Fabiano Rosas wro= te: > Peter Xu writes: > > > Keep migration thread names together, so it's easier to see a list of a= ll > > possible migration threads. > > > > Still two functional changes below besides the macro defintions: > > > > - There's one dirty rate thread that we overlooked before, now we add > > that too and name it as "mig/dirtyrate" following the old rules. > > > > - The old name "mig/src/rp-thr" has "-thr" but it may not be useful i= f > > it's a thread name anyway, while "rp" can be slightly hard to read. > > Taking this chance to rename it to "mig/src/return", hopefully a bett= er > > name. > > > > Signed-off-by: Peter Xu > > Reviewed-by: Fabiano Rosas > Acked-by: Hyman Huang --=20 Best regards --000000000000e5d655062442b43a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

<= /div>
O= n Sat, Oct 12, 2024 at 1:29=E2=80=AFAM Fabiano Rosas <farosas@suse.de> wrote:
=
Peter Xu <peterx@redhat.com> writes:

> Keep migration thread names together, so it's easier to see a list= of all
> possible migration threads.
>
> Still two functional changes below besides the macro defintions:
>
>=C2=A0 =C2=A0- There's one dirty rate thread that we overlooked bef= ore, now we add
>=C2=A0 =C2=A0that too and name it as "mig/dirtyrate" followin= g the old rules.
>
>=C2=A0 =C2=A0- The old name "mig/src/rp-thr" has "-thr&q= uot; but it may not be useful if
>=C2=A0 =C2=A0it's a thread name anyway, while "rp" can be= slightly hard to read.
>=C2=A0 =C2=A0Taking this chance to rename it to "mig/src/return&qu= ot;, hopefully a better
>=C2=A0 =C2=A0name.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>

Reviewed-by: Fabiano Rosas <farosas@suse.de>

Acked-by: Hyman Huan= g <yong.huang@smartx.com>= ;

--
Best regards
--000000000000e5d655062442b43a--