From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E1F7C47077 for ; Thu, 11 Jan 2024 15:55:31 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNxOO-0001Ot-6H; Thu, 11 Jan 2024 10:54:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNxOK-0001Oj-Ly for qemu-devel@nongnu.org; Thu, 11 Jan 2024 10:54:48 -0500 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNxOE-0002UB-P2 for qemu-devel@nongnu.org; Thu, 11 Jan 2024 10:54:46 -0500 Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-28b82dc11e6so3293541a91.1 for ; Thu, 11 Jan 2024 07:52:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smartx-com.20230601.gappssmtp.com; s=20230601; t=1704988358; x=1705593158; darn=nongnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KwuBge6OSP9GsLaivULUMKkyWjvhgEEm5Po2ddIf1co=; b=ktHu8J+AxvZb4mLTDEfDifJe+PO/BNVIcYnTtnB6+hOUDTk5DUsSUhoTFTsPXjiuak ZArWH8emGzlBWn8c1bxCPCsAjJFM4msdr1vlArQ4YDg/maWHz58PzXxiMJeeCfsA/6sI WWY7ATsVPnnLenvKPSrBklucv08vouiWiY9FlcnRbbs7fHdvedwM6u1c+iZMz2j6Kod/ pwoeq2Ol37bJsQ6k+oRzk7a/7idMXMXOyOCyOJG0mPqTUp4Q/KyZ5A0q8FVs3drNYdG0 CeN5fNtuOhpUdtFk8RDBrxrXBec8n7q8O2B/KTLr81logYs7Uug0dkGU7ZQrFwpdm/ZJ jEaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704988358; x=1705593158; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KwuBge6OSP9GsLaivULUMKkyWjvhgEEm5Po2ddIf1co=; b=bSSqSt/cw+e76eUzri7GpTAIYfPbvPW6SqEM8WNRV3yqKfA48sD5zkJ+ZKf3b7J7t8 P8+LYLAluzyA5Dv0IqEEz9EkXyff97QrfQdIxQjaLkjDuHryrpC134Gms6gcpj30UVTQ 0SPOeUYHKE5XneYQswnbRuUnZlriqTG1h64Soa4d1AHVl7IhplbPPqzEyZYtn/N0A3H/ ex9iOcPs2j3ffrLPVd0KnrukTtkCy+bCDTxT7lXuMF0ocZzCk+oJAF3nn/Zlv6IgD7uZ wNHMGy0utFfqmXE7GH1lRWfIQlF0E5oE3oWMVWWYbDkTXRyzE9cRSNVIPBaLNphGdJ7S Q2Tw== X-Gm-Message-State: AOJu0YzBdrTMMokPsjKuKnHES6uc31L7TWSwz9Bd7DU2VRgQFXqjpECs pKnTYJFQxUAw0dcSSXsGKZ2uW7VVTtdp0IRa0bT/ADTFXScXbw== X-Google-Smtp-Source: AGHT+IEJOpYquXVfUqO3U3t4Ybm+L7OBpicrVX4CVJRbZMTpEDRRgdc9LCxx0jrMcILLb1qxiblFRZCp4/UJqzTr8LI= X-Received: by 2002:a17:90a:1008:b0:28c:fb01:a2d5 with SMTP id b8-20020a17090a100800b0028cfb01a2d5mr1090587pja.67.1704988356582; Thu, 11 Jan 2024 07:52:36 -0800 (PST) MIME-Version: 1.0 References: <20ab47b728492cedb7ea671239f0397a141c3f5a.1703482349.git.yong.huang@smartx.com> <87o7dsufrk.fsf@pond.sub.org> In-Reply-To: <87o7dsufrk.fsf@pond.sub.org> From: Yong Huang Date: Thu, 11 Jan 2024 23:52:20 +0800 Message-ID: Subject: Re: [PATCH RESEND v3 06/10] block: Support detached LUKS header creation using blockdev-create To: Markus Armbruster Cc: qemu-devel , Kevin Wolf , =?UTF-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , Hanna Reitz , Eric Blake Content-Type: multipart/alternative; boundary="00000000000057331f060ead896b" Received-SPF: none client-ip=2607:f8b0:4864:20::1029; envelope-from=yong.huang@smartx.com; helo=mail-pj1-x1029.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --00000000000057331f060ead896b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jan 11, 2024 at 10:05=E2=80=AFPM Markus Armbruster wrote: > Fails to compile for me: > > ../block/crypto.c: In function =E2=80=98block_crypto_co_create_luks=E2=80= =99: > ../block/crypto.c:784:1: error: control reaches end of non-void function > [-Werror=3Dreturn-type] > 784 | } > | ^ > > Ok, I'll check it out and fix it in the next version. By the way, I'm stuck with some other work, so version 4 might not be finished for a few weeks, but I'll get to it as soon as I can. Thanks, Yong --=20 Best regards --00000000000057331f060ead896b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Jan 11, 20= 24 at 10:05=E2=80=AFPM Markus Armbruster <armbru@redhat.com> wrote:
Fails to = compile for me:

../block/crypto.c: In function =E2=80=98block_crypto_co_create_luks=E2=80= =99:
../block/crypto.c:784:1: error: control reaches end of non-void function [-= Werror=3Dreturn-type]
=C2=A0 784 | }
=C2=A0 =C2=A0 =C2=A0 | ^


Ok, I'll check i= t out and fix it in the next version.

By the way, I'm stuck with some other work, so version 4 might not = be finished for
a few weeks, but I'll get to it as so= on as I can.=C2=A0

Thanks,=C2=A0
=
Yong

-- =
Best regards
--00000000000057331f060ead896b--