From: Deepak Gupta <debug@rivosinc.com>
To: Alistair Francis <alistair23@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH: fix for virt instr exception] target/riscv: fix for virtual instr exception
Date: Tue, 7 Feb 2023 07:01:50 -0800 [thread overview]
Message-ID: <CAKC1njTcRGW2B1j-FAmHzmkZX6eNe8+rdp+0K-HC9jAP6-xX_Q@mail.gmail.com> (raw)
In-Reply-To: <CAKmqyKNUEiEODbhAd4MESN-dD2qm2jTVC90ko=7MFv1hBBdJhA@mail.gmail.com>
Thank you!
On Sun, Feb 5, 2023 at 4:02 PM Alistair Francis <alistair23@gmail.com> wrote:
>
> On Sat, Jan 28, 2023 at 6:36 AM Deepak Gupta <debug@rivosinc.com> wrote:
> >
> > commit fb3f3730e4 added mechanism to generate virtual instruction
> > exception during instruction decode when virt is enabled.
> >
> > However in some situations, illegal instruction exception can be raised
> > due to state of CPU. One such situation is implementing branch tracking.
> > [1] An indirect branch if doesn't land on a landing pad instruction, then
> > cpu must raise an illegal instruction exception.
> > Implementation would raise such expcetion due to missing landing pad inst
> > and not due to decode. Thus DisasContext must have `virt_inst_excp`
> > initialized to false during DisasContxt initialization for TB.
> >
> > [1] - https://github.com/riscv/riscv-cfi
> >
> > Signed-off-by: Deepak Gupta <debug@rivosinc.com>
>
> Thanks!
>
> Applied to riscv-to-apply.next
>
> Alistair
>
> > ---
> > target/riscv/translate.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/target/riscv/translate.c b/target/riscv/translate.c
> > index df38db7553..76f61a39d3 100644
> > --- a/target/riscv/translate.c
> > +++ b/target/riscv/translate.c
> > @@ -1167,6 +1167,7 @@ static void riscv_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cs)
> > ctx->pm_base_enabled = FIELD_EX32(tb_flags, TB_FLAGS, PM_BASE_ENABLED);
> > ctx->itrigger = FIELD_EX32(tb_flags, TB_FLAGS, ITRIGGER);
> > ctx->zero = tcg_constant_tl(0);
> > + ctx->virt_inst_excp = false;
> > }
> >
> > static void riscv_tr_tb_start(DisasContextBase *db, CPUState *cpu)
> > --
> > 2.25.1
> >
> >
prev parent reply other threads:[~2023-02-07 15:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 19:17 [PATCH: fix for virt instr exception] target/riscv: fix for virtual instr exception Deepak Gupta
2023-01-27 19:22 ` Deepak Gupta
2023-01-29 22:49 ` Alistair Francis
2023-02-01 20:50 ` Deepak Gupta
2023-02-05 23:21 ` Alistair Francis
2023-02-06 0:01 ` Alistair Francis
2023-02-07 15:01 ` Deepak Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKC1njTcRGW2B1j-FAmHzmkZX6eNe8+rdp+0K-HC9jAP6-xX_Q@mail.gmail.com \
--to=debug@rivosinc.com \
--cc=alistair23@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).