qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Willian Rampazzo <wrampazz@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
	"Laurent Vivier" <laurent@vivier.eu>,
	qemu-devel@nongnu.org, "Cleber Rosa" <crosa@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Beraldo Leal" <bleal@redhat.com>
Subject: Re: [PATCH-for-5.0? v2 2/2] Revert "Acceptance test: cancel test if m68k kernel packages goes missing"
Date: Wed, 27 Nov 2019 11:53:49 -0300	[thread overview]
Message-ID: <CAKJDGDY21sjoQ9rvDWvRnwMobgg37ARM3Nj6Ajo6XQaLv4GFtA@mail.gmail.com> (raw)
In-Reply-To: <20191126223810.20180-3-philmd@redhat.com>

On Tue, Nov 26, 2019 at 7:38 PM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> Now than we use the stable snapshot archive, we can remove this check.
>
> This reverts commit d2499aca4bac613d837e2720e7bbe3378bc91245.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  tests/acceptance/boot_linux_console.py | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py
> index 752f776f68..ab4c8a5e5a 100644
> --- a/tests/acceptance/boot_linux_console.py
> +++ b/tests/acceptance/boot_linux_console.py
> @@ -483,10 +483,7 @@ class BootLinuxConsole(Test):
>                     '/20191021T083923Z/pool-m68k/main'
>                     '/l/linux/kernel-image-5.3.0-1-m68k-di_5.3.7-1_m68k.udeb')
>          deb_hash = '044954bb9be4160a3ce81f8bc1b5e856b75cccd1'
> -        try:
> -            deb_path = self.fetch_asset(deb_url, asset_hash=deb_hash)
> -        except OSError as exp:
> -            self.cancel(exp)
> +        deb_path = self.fetch_asset(deb_url, asset_hash=deb_hash)
>          kernel_path = self.extract_from_deb(deb_path,
>                                              '/boot/vmlinux-5.3.0-1-m68k')
>

Tested-by: Willian Rampazzo <wrampazz@redhat.com>

Although I prefer to be on the safe side and keep the verification,
the code works as expected.

---
Willian



  reply	other threads:[~2019-11-27 14:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-26 22:38 [PATCH-for-4.2? v2 0/2] tests/acceptance: Fix the m68k/q800 Linux test Philippe Mathieu-Daudé
2019-11-26 22:38 ` [PATCH-for-4.2? v2 1/2] tests/boot_linux_console: Fetch assets from Debian snapshot archives Philippe Mathieu-Daudé
2019-11-27 14:51   ` Willian Rampazzo
2019-12-06 14:46   ` Cleber Rosa
2019-12-06 15:07     ` Philippe Mathieu-Daudé
2019-11-26 22:38 ` [PATCH-for-5.0? v2 2/2] Revert "Acceptance test: cancel test if m68k kernel packages goes missing" Philippe Mathieu-Daudé
2019-11-27 14:53   ` Willian Rampazzo [this message]
2019-11-27 15:06     ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKJDGDY21sjoQ9rvDWvRnwMobgg37ARM3Nj6Ajo6XQaLv4GFtA@mail.gmail.com \
    --to=wrampazz@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=bleal@redhat.com \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=laurent@vivier.eu \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).