From: Willian Rampazzo <wrampazz@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>, Cleber Rosa <crosa@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [PATCH 3/7] python/machine: add instance disambiguator to default nickname
Date: Fri, 19 Nov 2021 09:24:52 -0300 [thread overview]
Message-ID: <CAKJDGDaOzTxNdSShon394FjKgyxLihqeKjaB-E_Wm0bbCLAzpw@mail.gmail.com> (raw)
In-Reply-To: <20211118204620.1897674-4-jsnow@redhat.com>
On Thu, Nov 18, 2021 at 5:49 PM John Snow <jsnow@redhat.com> wrote:
>
> If you create two instances of QEMUMachine(), they'll both create the
> same nickname by default -- which is not that helpful.
>
> Luckily, they'll both create unique temporary directories ... but due to
> user configuration, they may share logging and sockfile directories,
> meaning two instances can collide. The Python logging will also be quite
> confusing, with no differentiation between the two instances.
>
> Add an instance disambiguator (The memory address of the instance) to
> the default nickname to foolproof this in all cases.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/qemu/machine/machine.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
next prev parent reply other threads:[~2021-11-19 12:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 20:46 [PATCH 0/7] python: More fixes for 6.2 John Snow
2021-11-18 20:46 ` [PATCH 1/7] python/machine: add @sock_dir property John Snow
2021-11-19 12:21 ` Willian Rampazzo
2021-11-18 20:46 ` [PATCH 2/7] python/machine: remove _remove_monitor_sockfile property John Snow
2021-11-19 12:22 ` Willian Rampazzo
2021-11-18 20:46 ` [PATCH 3/7] python/machine: add instance disambiguator to default nickname John Snow
2021-11-19 8:54 ` Philippe Mathieu-Daudé
2021-11-19 12:24 ` Willian Rampazzo [this message]
2021-11-18 20:46 ` [PATCH 4/7] python/machine: move more variable initializations to _pre_launch John Snow
2021-11-19 12:26 ` Willian Rampazzo
2021-11-18 20:46 ` [PATCH 5/7] python/machine: handle "fast" QEMU terminations John Snow
2021-11-19 16:09 ` Willian Rampazzo
2021-11-18 20:46 ` [PATCH 6/7] scripts/device-crash-test: Use a QMP timeout John Snow
2021-11-18 20:46 ` [PATCH 7/7] python/aqmp: fix send_fd_scm for python 3.6.x John Snow
2021-11-19 16:18 ` Willian Rampazzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKJDGDaOzTxNdSShon394FjKgyxLihqeKjaB-E_Wm0bbCLAzpw@mail.gmail.com \
--to=wrampazz@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).