Re: [PATCH v2] tests/acceptance: Skip slow quanta-gsj U-boot+Linux test

[Willian Rampazzo <wrampazz@redhat.com>]

On Fri, Sep 18, 2020 at 11:35 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The 'arm_quanta_gsj_initrd' test is timeouting on GitLab CI:
> https://gitlab.com/philmd/qemu/-/jobs/745483978#L846
> and also sometimes on my workstation, so proceed as with
> the other slow tests: do not run it by default.
> The test can still be run setting the AVOCADO_TIMEOUT_EXPECTED
> environment variable.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Supersedes: <20200918142344.150749-1-f4bug@amsat.org>
> ---
>  tests/acceptance/boot_linux_console.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py
> index 4a366ce93e4..9b58f6f9003 100644
> --- a/tests/acceptance/boot_linux_console.py
> +++ b/tests/acceptance/boot_linux_console.py
> @@ -568,6 +568,7 @@ def test_arm_cubieboard_sata(self):
>                                                  'sda')
>          # cubieboard's reboot is not functioning; omit reboot test.
>
> +    @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
>      def test_arm_quanta_gsj(self):
>          """
>          :avocado: tags=arch:arm
> --
> 2.26.2
>
>

At least, this time, skipUnless is already there :D

Reviewed-by: Willian Rampazzo <willianr@redhat.com>