From: Willian Rampazzo <wrampazz@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel <qemu-devel@nongnu.org>,
qemu-block@nongnu.org
Subject: Re: [PATCH v3 09/10] iotests/129: Clean up pylint and mypy complaints
Date: Fri, 15 Jan 2021 11:43:27 -0300 [thread overview]
Message-ID: <CAKJDGDb4H-_-k-_8karHWieAFTW6wXCYzE-ni60+dxbunPr9nA@mail.gmail.com> (raw)
In-Reply-To: <3bba8b87-da1a-b951-bb1f-835ee85b00b8@redhat.com>
On Fri, Jan 15, 2021 at 6:30 AM Max Reitz <mreitz@redhat.com> wrote:
>
> On 14.01.21 21:02, Willian Rampazzo wrote:
> > On Thu, Jan 14, 2021 at 2:41 PM Max Reitz <mreitz@redhat.com> wrote:
> >>
> >> Signed-off-by: Max Reitz <mreitz@redhat.com>
> >> ---
> >> tests/qemu-iotests/129 | 4 ++--
> >> tests/qemu-iotests/297 | 2 +-
> >> 2 files changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/tests/qemu-iotests/129 b/tests/qemu-iotests/129
> >> index 6d21470cd7..201d9e0a0b 100755
> >> --- a/tests/qemu-iotests/129
> >> +++ b/tests/qemu-iotests/129
> >> @@ -20,7 +20,6 @@
> >>
> >> import os
> >> import iotests
> >> -import time
> >>
> >> class TestStopWithBlockJob(iotests.QMPTestCase):
> >> test_img = os.path.join(iotests.test_dir, 'test.img')
> >> @@ -32,7 +31,8 @@ class TestStopWithBlockJob(iotests.QMPTestCase):
> >> iotests.qemu_img('create', '-f', iotests.imgfmt, self.base_img, "1G")
> >> iotests.qemu_img('create', '-f', iotests.imgfmt, self.test_img,
> >> "-b", self.base_img, '-F', iotests.imgfmt)
> >> - iotests.qemu_io('-f', iotests.imgfmt, '-c', 'write -P0x5d 1M 128M', self.test_img)
> >> + iotests.qemu_io('-f', iotests.imgfmt, '-c', 'write -P0x5d 1M 128M',
> >> + self.test_img)
> >> self.vm = iotests.VM()
> >> self.vm.add_object('throttle-group,id=tg0,x-bps-total=1024')
> >>
> >> diff --git a/tests/qemu-iotests/297 b/tests/qemu-iotests/297
> >> index bfa26d280b..1dce1d1b1c 100755
> >> --- a/tests/qemu-iotests/297
> >> +++ b/tests/qemu-iotests/297
> >> @@ -27,7 +27,7 @@ import iotests
> >> # TODO: Empty this list!
> >> SKIP_FILES = (
> >> '030', '040', '041', '044', '045', '055', '056', '057', '065', '093',
> >> - '096', '118', '124', '129', '132', '136', '139', '147', '148', '149',
> >> + '096', '118', '124', '132', '136', '139', '147', '148', '149',
> >
> > Is this also part of mypy/pylint cleanup? It seems you are doing more
> > than that here. It would be good to have this listed in the commit
> > message.
>
> Sure, why not. Something like “And consequentially drop it from 297's
> skip list.”?
+1 Thanks!
>
> Though I think making a test pass pylint+mypy complaints basically means
> exactly to remove it from 297's skip list and then making 297 pass, so
> I’m not entirely sure it’s necessary. But it can’t hurt, so.
>
> > Despite that,
> >
> > Reviewed-by: Willian Rampazzo <willianr@redhat.com>
>
> Thanks!
>
> Max
>
> >> '151', '152', '155', '163', '165', '169', '194', '196', '199', '202',
> >> '203', '205', '206', '207', '208', '210', '211', '212', '213', '216',
> >> '218', '219', '222', '224', '228', '234', '235', '236', '237', '238',
> >> --
> >> 2.29.2
> >>
> >>
> >
>
next prev parent reply other threads:[~2021-01-15 14:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 17:02 [PATCH v3 00/10] iotests: Fix 129 and expand 297’s reach Max Reitz
2021-01-14 17:02 ` [PATCH v3 01/10] iotests.py: Assume a couple of variables as given Max Reitz
2021-01-15 9:19 ` Vladimir Sementsov-Ogievskiy
2021-01-14 17:02 ` [PATCH v3 02/10] iotests/297: Rewrite in Python and extend reach Max Reitz
2021-01-15 11:13 ` Vladimir Sementsov-Ogievskiy
2021-01-15 11:57 ` Max Reitz
2021-01-15 12:37 ` Vladimir Sementsov-Ogievskiy
2021-01-14 17:02 ` [PATCH v3 03/10] iotests: Move try_remove to iotests.py Max Reitz
2021-01-15 11:14 ` Vladimir Sementsov-Ogievskiy
2021-01-14 17:02 ` [PATCH v3 04/10] iotests/129: Remove test images in tearDown() Max Reitz
2021-01-15 14:48 ` Willian Rampazzo
2021-01-14 17:02 ` [PATCH v3 05/10] iotests/129: Do not check @busy Max Reitz
2021-01-14 17:03 ` [PATCH v3 06/10] iotests/129: Use throttle node Max Reitz
2021-01-15 11:16 ` Vladimir Sementsov-Ogievskiy
2021-01-15 11:58 ` Max Reitz
2021-01-14 17:03 ` [PATCH v3 07/10] iotests/129: Actually test a commit job Max Reitz
2021-01-14 17:03 ` [PATCH v3 08/10] iotests/129: Limit mirror job's buffer size Max Reitz
2021-01-15 14:49 ` Willian Rampazzo
2021-01-14 17:03 ` [PATCH v3 09/10] iotests/129: Clean up pylint and mypy complaints Max Reitz
2021-01-14 20:02 ` Willian Rampazzo
2021-01-15 9:30 ` Max Reitz
2021-01-15 14:43 ` Willian Rampazzo [this message]
2021-01-15 11:18 ` Vladimir Sementsov-Ogievskiy
2021-01-14 17:03 ` [PATCH v3 10/10] iotests/300: " Max Reitz
2021-01-15 11:30 ` Vladimir Sementsov-Ogievskiy
2021-01-15 11:59 ` Max Reitz
2021-01-15 11:53 ` [PATCH v3 11/10] iotests: add flake8 linter Vladimir Sementsov-Ogievskiy
2021-01-15 12:03 ` Max Reitz
2021-01-15 13:30 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKJDGDb4H-_-k-_8karHWieAFTW6wXCYzE-ni60+dxbunPr9nA@mail.gmail.com \
--to=wrampazz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).