qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Li Qiang <liq3ea@gmail.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Sarah Harris <S.E.Harris@kent.ac.uk>,
	Stefan Weil <sw@weilnetz.de>,
	Qemu Developers <qemu-devel@nongnu.org>,
	Michael Rolnik <mrolnik@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH-for-5.1 3/4] qemu-common: Document qemu_find_file()
Date: Wed, 15 Jul 2020 09:04:56 +0800	[thread overview]
Message-ID: <CAKXe6S+KnKpgcaJ5MairhWpYJ3vGu8Fs12aD1i1onERm2x46rg@mail.gmail.com> (raw)
In-Reply-To: <20200714164257.23330-4-f4bug@amsat.org>

Philippe Mathieu-Daudé <f4bug@amsat.org> 于2020年7月15日周三 上午12:48写道:
>
> Document qemu_find_file(), in particular the returned
> value which must be freed.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Li Qiang <liq3ea@gmail.com>

> ---
>  include/qemu-common.h | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/include/qemu-common.h b/include/qemu-common.h
> index d0142f29ac..d6a08259d3 100644
> --- a/include/qemu-common.h
> +++ b/include/qemu-common.h
> @@ -110,6 +110,20 @@ const char *qemu_get_vm_name(void);
>
>  #define QEMU_FILE_TYPE_BIOS   0
>  #define QEMU_FILE_TYPE_KEYMAP 1
> +/**
> + * qemu_find_file:
> + * @type: QEMU_FILE_TYPE_BIOS (for BIOS, VGA BIOS)
> + *        or QEMU_FILE_TYPE_KEYMAP (for keymaps).
> + * @name: File name
> + *
> + * Search for @name file in the data directories, either configured at
> + * build time (DATADIR) or registered with the -L command line option.
> + *
> + * The caller must use g_free() to free the returned data when it is
> + * no longer required.
> + *
> + * Returns: absolute path to the file or NULL on error.
> + */
>  char *qemu_find_file(int type, const char *name);
>
>  /* OS specific functions */
> --
> 2.21.3
>
>


  parent reply	other threads:[~2020-07-15  1:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14 16:42 [PATCH-for-5.1 0/4] misc: Document qemu_find_file and fix memory leak in avr_load_firmware Philippe Mathieu-Daudé
2020-07-14 16:42 ` [PATCH-for-5.1 1/4] qemu/osdep: Document os_find_datadir() return value Philippe Mathieu-Daudé
2020-07-20 14:10   ` Daniel P. Berrangé
2020-07-14 16:42 ` [PATCH-for-5.1 2/4] qemu/osdep: Reword qemu_get_exec_dir() documentation Philippe Mathieu-Daudé
2020-07-20 14:10   ` Daniel P. Berrangé
2020-07-14 16:42 ` [PATCH-for-5.1 3/4] qemu-common: Document qemu_find_file() Philippe Mathieu-Daudé
2020-07-14 18:41   ` Peter Maydell
2020-07-15  1:04   ` Li Qiang [this message]
2020-07-20 14:16   ` Daniel P. Berrangé
2020-07-20 18:43     ` Philippe Mathieu-Daudé
2020-07-14 16:42 ` [PATCH-for-5.1 4/4] hw/avr/boot: Fix memory leak in avr_load_firmware() Philippe Mathieu-Daudé
2020-07-20 12:39   ` Philippe Mathieu-Daudé
2020-07-20 14:18   ` Daniel P. Berrangé
2020-07-20 18:45     ` Philippe Mathieu-Daudé
2020-07-20 13:24 ` [PATCH-for-5.1 0/4] misc: Document qemu_find_file and fix memory leak in avr_load_firmware Michael Rolnik
2020-07-20 13:38   ` Michael Rolnik
2020-07-20 18:48 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKXe6S+KnKpgcaJ5MairhWpYJ3vGu8Fs12aD1i1onERm2x46rg@mail.gmail.com \
    --to=liq3ea@gmail.com \
    --cc=S.E.Harris@kent.ac.uk \
    --cc=f4bug@amsat.org \
    --cc=mrolnik@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).