From: Li Qiang <liq3ea@gmail.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-trivial@nongnu.org, Jason Wang <jasowang@redhat.com>,
Dmitry Fleytman <dmitry.fleytman@gmail.com>,
Qemu Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH 2/2] hw/net/e1000e: Remove duplicated write handler for FLSWDATA register
Date: Sat, 5 Sep 2020 08:58:10 +0800 [thread overview]
Message-ID: <CAKXe6SJ6nrAm-LDK_gv__5vcK4Py62zQ7-RfVJodAghuMfdfJw@mail.gmail.com> (raw)
In-Reply-To: <20200904131402.590055-3-f4bug@amsat.org>
Philippe Mathieu-Daudé <f4bug@amsat.org> 于2020年9月4日周五 下午9:14写道：
>
> The FLSWDATA register writeop handler is initialized twice:
>
> 3067 #define e1000e_putreg(x) [x] = e1000e_mac_writereg
> 3068 typedef void (*writeops)(E1000ECore *, int, uint32_t);
> 3069 static const writeops e1000e_macreg_writeops[] = {
> ....
> 3102 e1000e_putreg(FLSWDATA),
> ....
> 3145 e1000e_putreg(FLSWDATA),
>
> To avoid confusion, remove the duplicated initialization.
>
> Fixes: 6f3fbe4ed0 ("net: Introduce e1000e device emulation")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
> ---
> Noticed after looking for other cases of the previous patch.
> ---
> hw/net/e1000e_core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
> index 5170e6a4563..bcfd46696ff 100644
> --- a/hw/net/e1000e_core.c
> +++ b/hw/net/e1000e_core.c
> @@ -3141,7 +3141,6 @@ static const writeops e1000e_macreg_writeops[] = {
> e1000e_putreg(RXCFGL),
> e1000e_putreg(TSYNCRXCTL),
> e1000e_putreg(TSYNCTXCTL),
> - e1000e_putreg(FLSWDATA),
> e1000e_putreg(EXTCNF_SIZE),
> e1000e_putreg(EEMNGCTL),
> e1000e_putreg(RA),
> --
> 2.26.2
>
>
next prev parent reply other threads:[~2020-09-05 0:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 13:14 [PATCH 0/2] hw/net/e1000e: Remove overwritten/duplicated register handlers Philippe Mathieu-Daudé
2020-09-04 13:14 ` [PATCH 1/2] hw/net/e1000e: Remove overwritten read handler for STATUS register Philippe Mathieu-Daudé
2020-09-05 0:57 ` Li Qiang
2020-09-09 13:47 ` Laurent Vivier
2020-09-04 13:14 ` [PATCH 2/2] hw/net/e1000e: Remove duplicated write handler for FLSWDATA register Philippe Mathieu-Daudé
2020-09-05 0:58 ` Li Qiang [this message]
2020-09-09 13:49 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKXe6SJ6nrAm-LDK_gv__5vcK4Py62zQ7-RfVJodAghuMfdfJw@mail.gmail.com \
--to=liq3ea@gmail.com \
--cc=dmitry.fleytman@gmail.com \
--cc=f4bug@amsat.org \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).