From: Li Qiang <liq3ea@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Qemu Developers <qemu-devel@nongnu.org>,
qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] memory.h: fix types in comments
Date: Tue, 9 Oct 2018 18:37:56 +0800 [thread overview]
Message-ID: <CAKXe6SJGpJVeaqs5boqWZqtVjKornk6TEEWhUd7TFnnfb-eOSg@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA9HOhtPbAOrbvRQfrnfcq14WuW+a5w=EXG3+-9t6Wfx5Q@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> 于2018年10月9日周二 下午6:26写道：
> On 9 October 2018 at 11:21, Li Qiang <liq3ea@gmail.com> wrote:
> > Signed-off-by: Li Qiang <liq3ea@gmail.com>
> > ---
> > include/exec/memory.h | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
>
> Thanks. Contents of patch
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> but the commit message should say "fix typos", not "fix types"
> (a 'typo' is a typing mistake; a 'type' is something like "uint32_t".)
>
>
Indeed, hope the maintainer can fix this typo when queuing this patch, :)
In additon, Cc: qemu-trivial@nongnu.org
>
> thanks
> -- PMM
>
next prev parent reply other threads:[~2018-10-09 10:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 10:21 [Qemu-devel] [PATCH] memory.h: fix types in comments Li Qiang
2018-10-09 10:25 ` Peter Maydell
2018-10-09 10:37 ` Li Qiang [this message]
2018-10-25 13:54 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKXe6SJGpJVeaqs5boqWZqtVjKornk6TEEWhUd7TFnnfb-eOSg@mail.gmail.com \
--to=liq3ea@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).