From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18D74C63697 for ; Thu, 26 Nov 2020 10:38:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42ADE20BED for ; Thu, 26 Nov 2020 10:38:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lpYcEQnk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42ADE20BED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiEfq-00082i-MN for qemu-devel@archiver.kernel.org; Thu, 26 Nov 2020 05:38:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiEek-0007EO-LJ; Thu, 26 Nov 2020 05:37:42 -0500 Received: from mail-ot1-x341.google.com ([2607:f8b0:4864:20::341]:42302) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kiEej-0004H7-8y; Thu, 26 Nov 2020 05:37:42 -0500 Received: by mail-ot1-x341.google.com with SMTP id 11so1469004oty.9; Thu, 26 Nov 2020 02:37:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=2shOX+HFGjx9yof2t8AsTuEfNL0YMKvC4gSmFolDGQY=; b=lpYcEQnkmOJlR6C2GvlgFoc9TPG5YFUItL13tg5rv5f+NMCCYdWBYHUk9Jr5Sx8uSC XAlheBcPj3iWwqdfhnTBeK3dC/6pTcU2gCYFOwhLbioSX17P5i966QH09k5Y272f+Ozd MMDY+5JoxHnY2R+A9O0IPaULtjbfcxs+z5x0YlNtdzk3c9BFHbUg3eZVqcl3B8u+KBGe 8ZTk+3sOnVGoTOEXAILIJvcuQKYcoLbMS1IDqs8rNTAub4+qDfR4Pw7ejHPhf1gZDDDm yIUv44G1LHpa2+5Sb/kqzK17Ue7ZqM8K2tyT1I8f46KxJhh24UTuxV6nbvY/IY0cla8r DmTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=2shOX+HFGjx9yof2t8AsTuEfNL0YMKvC4gSmFolDGQY=; b=crweY5UbhQyT81/9yJKanNr0rtA7YM5mmLZT5N2BbaYNZj1jYyjjyB4d4RZmsFKr/x uVzQcItr59MIXs2SakTOh/GQERCYQY26dk5v/ae59EI7AH9USU8x5rny5+hQ/rY8vVOY G+b5Oujal1c5P4KCE8xz8eOF0kGw3HI8PO1Oe9Ky44zhBX25smfCDo0ES4OxODOeRmiK s1mazAAb+ClX+oTND6svSXls64Tr6HGiOhhjMmaYjIVtrgNFcNjtQHjfGHav2oWz4/mC 7g0Pbgglz/hqJ9hWMkqBEfArxK25YsAL/dkqlCb2vTqkGnasmFD/EXC9lxgIvv7ysU5b /KlA== X-Gm-Message-State: AOAM532jlIjkz9o8JDU6xbhiKWmNk0GGi1tMsvxm3o3xVCylwOrbO88i OLW7NEM4xK6wuMnmri9qWqnztENuTlhtYoU0JFI= X-Google-Smtp-Source: ABdhPJwYEFlO61IOOuH68cppSd9RmtPzOakXuEMmsZOGSPMJZF3IswLWSXuRpNF7SpL9anXymaSzZUx2nOkXW6ll+8k= X-Received: by 2002:a9d:7e96:: with SMTP id m22mr1855365otp.181.1606387059699; Thu, 26 Nov 2020 02:37:39 -0800 (PST) MIME-Version: 1.0 References: <20201125102403.57709-1-alex.chen@huawei.com> In-Reply-To: <20201125102403.57709-1-alex.chen@huawei.com> From: Li Qiang Date: Thu, 26 Nov 2020 18:37:03 +0800 Message-ID: Subject: Re: [PATCH] test-qga: fix a resource leak in test_qga_guest_get_osinfo() To: Alex Chen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::341; envelope-from=liq3ea@gmail.com; helo=mail-ot1-x341.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, zhanghailiang , Michael Roth , Qemu Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Alex Chen =E4=BA=8E2020=E5=B9=B411=E6=9C=8825=E6=97= =A5=E5=91=A8=E4=B8=89 =E4=B8=8B=E5=8D=886:37=E5=86=99=E9=81=93=EF=BC=9A > > The fixture->fd is created in fixture_setup() and, likewise, needs to be = closed > in fixture_tear_down(). > > Reported-by: Euler Robot > Signed-off-by: Alex Chen Reviewed-by: Li Qiang > --- > tests/test-qga.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/test-qga.c b/tests/test-qga.c > index c1b173b3cb..eb33264e8e 100644 > --- a/tests/test-qga.c > +++ b/tests/test-qga.c > @@ -111,6 +111,7 @@ fixture_tear_down(TestFixture *fixture, gconstpointer= data) > > g_rmdir(fixture->test_dir); > g_free(fixture->test_dir); > + close(fixture->fd); > } > > static void qmp_assertion_message_error(const char *domain, > -- > 2.19.1 > >