From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 729C8C433E2 for ; Mon, 7 Sep 2020 01:16:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00D412080A for ; Mon, 7 Sep 2020 01:16:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RmpCfALI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00D412080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55444 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kF5lo-0006A5-1S for qemu-devel@archiver.kernel.org; Sun, 06 Sep 2020 21:16:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kF5ka-0004cH-Sz; Sun, 06 Sep 2020 21:15:16 -0400 Received: from mail-ot1-x344.google.com ([2607:f8b0:4864:20::344]:44268) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kF5kZ-00034N-18; Sun, 06 Sep 2020 21:15:16 -0400 Received: by mail-ot1-x344.google.com with SMTP id a2so10982035otr.11; Sun, 06 Sep 2020 18:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=1loAEISkJKUavZrT3lSKkYTAByy0U7cdnzxNpw76mIs=; b=RmpCfALI/msotsbAaGwvZ7Kdt/QVIiTAArVrTdum3I4sQ6aAy9j7yQgiFqy1GK03H7 O4G2vwRRxgmoGRMipc1+xP2o8fwgNDTnwHeI61mb3JzxPxi4IbaS6sWTq7fvjg4C3EPw AxUt2QC8GxvJoL7MbTFhLQQhEshqeQ7VkfkVye74SWM1RQc/YzFMZNzDba70QPMZpIQW icQYqZkLEoZ1H1WaIJY5k99bHn/hrHDSFVZHWus7M7SJkJiTVEaCVU79HFKBigdKAChC BlXRFIc3Yzgofr+tCoxqH+bZFMPLlEifEWg65CFqFPH3F0FvZZYUJHgunEqPYmsl1O0e J5rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=1loAEISkJKUavZrT3lSKkYTAByy0U7cdnzxNpw76mIs=; b=DWaBT8DRbpoGs7eET3kvLWESZ9cB31zd3fZBLj4wYLPVYQ5sJ2HYUctSTJ+0V3uMOB 2HyGtvzcux99H77HFaO0J50vrcRrYKPUYNqf0dIyxl6DUVsKH9Vw5IzE2rprFh7Y8JRV bG/UDNb0nvqu2BTzaz+NjJw2b2go3BBK48x589ssA37uOdx5ninDEP+Ru3xvWg8t1sHD jeky9CjopzHiPtzNct6IRY+HUbUJ4r6ugd7C/MV5j5B7VQSt6/z+FDG8E4PeUfm6zLo1 qFuOzMYDgZFA1CCMFptfrZ7jmhsmCVx59CjfHzsnxoFZIDiCWx3it8MEKs6Ms9o61iVg tQ/Q== X-Gm-Message-State: AOAM533dlEF+dUKshyztxbJsuODI/776fFO8Jam/Gc+iSGs4j/UhssQp A698hZqeXuSEPeAsWT9pI25e+z3qGmxD11KyovU= X-Google-Smtp-Source: ABdhPJxZ42/b89IG6urApE+79qjxZCdOk+UTuy36+xOtx3jBLKaUmDuSQ0jNbkpCJOBMmHfQ89HS/M2lNfdhocjId8g= X-Received: by 2002:a05:6830:610:: with SMTP id w16mr12175814oti.353.1599441312796; Sun, 06 Sep 2020 18:15:12 -0700 (PDT) MIME-Version: 1.0 References: <20200904154439.643272-1-philmd@redhat.com> <20200904154439.643272-11-philmd@redhat.com> In-Reply-To: <20200904154439.643272-11-philmd@redhat.com> From: Li Qiang Date: Mon, 7 Sep 2020 09:14:36 +0800 Message-ID: Subject: Re: [PATCH 10/13] dma: Let dma_memory_rw_relaxed() take MemTxAttrs argument To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::344; envelope-from=liq3ea@gmail.com; helo=mail-ot1-x344.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S. Tsirkin" , Jason Wang , Mark Cave-Ayland , Qemu Developers , Peter Xu , Gerd Hoffmann , "Edgar E. Iglesias" , qemu-block@nongnu.org, Peter Chubb , Joel Stanley , Richard Henderson , Laszlo Ersek , Eduardo Habkost , Alistair Francis , Beniamino Galvani , Eric Auger , qemu-arm@nongnu.org, Jan Kiszka , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , John Snow , David Gibson , Andrew Jeffery , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Andrew Baumann , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Philippe Mathieu-Daud=C3=A9 =E4=BA=8E2020=E5=B9=B49=E6= =9C=884=E6=97=A5=E5=91=A8=E4=BA=94 =E4=B8=8B=E5=8D=8811:53=E5=86=99=E9=81= =93=EF=BC=9A > > We will add the MemTxAttrs argument to dma_memory_rw() in > the next commit. Since dma_memory_rw_relaxed() is only used > by dma_memory_rw(), modify it first in a separate commit to > keep the next commit easier to review. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Li Qiang > --- > include/sysemu/dma.h | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/include/sysemu/dma.h b/include/sysemu/dma.h > index d0381f9ae9b..59331ec0bd3 100644 > --- a/include/sysemu/dma.h > +++ b/include/sysemu/dma.h > @@ -83,9 +83,10 @@ static inline bool dma_memory_valid(AddressSpace *as, > static inline MemTxResult dma_memory_rw_relaxed(AddressSpace *as, > dma_addr_t addr, > void *buf, dma_addr_t le= n, > - DMADirection dir) > + DMADirection dir, > + MemTxAttrs attrs) > { > - return address_space_rw(as, addr, MEMTXATTRS_UNSPECIFIED, > + return address_space_rw(as, addr, attrs, > buf, len, dir =3D=3D DMA_DIRECTION_FROM_DEVI= CE); > } > > @@ -93,7 +94,9 @@ static inline MemTxResult dma_memory_read_relaxed(Addre= ssSpace *as, > dma_addr_t addr, > void *buf, dma_addr_t = len) > { > - return dma_memory_rw_relaxed(as, addr, buf, len, DMA_DIRECTION_TO_DE= VICE); > + return dma_memory_rw_relaxed(as, addr, buf, len, > + DMA_DIRECTION_TO_DEVICE, > + MEMTXATTRS_UNSPECIFIED); > } > > static inline MemTxResult dma_memory_write_relaxed(AddressSpace *as, > @@ -102,7 +105,8 @@ static inline MemTxResult dma_memory_write_relaxed(Ad= dressSpace *as, > dma_addr_t len) > { > return dma_memory_rw_relaxed(as, addr, (void *)buf, len, > - DMA_DIRECTION_FROM_DEVICE); > + DMA_DIRECTION_FROM_DEVICE, > + MEMTXATTRS_UNSPECIFIED); > } > > /** > @@ -124,7 +128,8 @@ static inline MemTxResult dma_memory_rw(AddressSpace = *as, dma_addr_t addr, > { > dma_barrier(as, dir); > > - return dma_memory_rw_relaxed(as, addr, buf, len, dir); > + return dma_memory_rw_relaxed(as, addr, buf, len, dir, > + MEMTXATTRS_UNSPECIFIED); > } > > /** > -- > 2.26.2 > >