From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXPVl-0004Aa-BX for qemu-devel@nongnu.org; Thu, 13 Dec 2018 06:50:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXPVk-0007g0-HZ for qemu-devel@nongnu.org; Thu, 13 Dec 2018 06:50:37 -0500 Received: from mail-io1-xd41.google.com ([2607:f8b0:4864:20::d41]:45984) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gXPVk-0007fg-Bs for qemu-devel@nongnu.org; Thu, 13 Dec 2018 06:50:36 -0500 Received: by mail-io1-xd41.google.com with SMTP id n3so1314333iog.12 for ; Thu, 13 Dec 2018 03:50:36 -0800 (PST) MIME-Version: 1.0 References: <1544701071-2922-1-git-send-email-liq3ea@gmail.com> In-Reply-To: From: Li Qiang Date: Thu, 13 Dec 2018 19:49:59 +0800 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] util: check the return value of fcntl in qemu_set_{block, nonblock} List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: marcandre lureau , Paolo Bonzini , "Daniel P. Berrange" , Qemu Developers , =?UTF-8?B?5p2O5by6?= Peter Maydell =E4=BA=8E2018=E5=B9=B412=E6=9C=881= 3=E6=97=A5=E5=91=A8=E5=9B=9B =E4=B8=8B=E5=8D=887:45=E5=86=99=E9=81=93=EF=BC= =9A > On Thu, 13 Dec 2018 at 11:37, Li Qiang wrote: > > > > Also add diagnostics info in 'qemu_set_cloexec' so that we can know > > what happen when error occurs. > > > > Signed-off-by: Li Qiang > > --- > > Change since v1: add diagnostics info > > We need to fix the assert in the test suite first... > Agree, as I mentioned in the last email, this assert seems occurs in aarch64. But I have no this environment. So this patch add diagnostics info to let the bot tell us what happen. Thanks, Li Qiang > thanks > -- PMM >