From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57717) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bp4Nm-00065e-EA for qemu-devel@nongnu.org; Tue, 27 Sep 2016 22:14:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bp4Nl-0004LC-8n for qemu-devel@nongnu.org; Tue, 27 Sep 2016 22:14:02 -0400 Received: from mail-io0-x236.google.com ([2607:f8b0:4001:c06::236]:34693) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bp4Nl-0004L2-3O for qemu-devel@nongnu.org; Tue, 27 Sep 2016 22:14:01 -0400 Received: by mail-io0-x236.google.com with SMTP id e66so35128990iod.1 for ; Tue, 27 Sep 2016 19:14:01 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20160927184010.0ef68530@bahia.lab.toulouse-stg.fr.ibm.com> References: <57ea5b9f.87941c0a.d0b87.d5b6@mx.google.com> <20160927184010.0ef68530@bahia.lab.toulouse-stg.fr.ibm.com> From: =?UTF-8?B?5p2O5by6?= Date: Wed, 28 Sep 2016 10:14:00 +0800 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH] 9pfs: make unmarshal V9fsString more robust List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: aneesh.kumar@linux.vnet.ibm.com, qemu-devel@nongnu.org, Li Qiang On 2016-09-28 0:40 GMT+08:00 Greg Kurz wrote: > > Talking about robustness was appropriate for your previous patches, but > it does not really apply here since v9fs_iov_vunmarshal() does not have > any issue with empty strings actually. > > I've changed the title to: > > 9pfs: allocate space for guest originated empty strings > > And while here, I've updated the changelog to provide a more detailed > justification: > > ... Thanks very much to point out the mistakes, I will do more next time. BTW, need I resend this patch formally? Thanks.