Re: [Qemu-devel] [PATCH] Makefile: Set default locale C

[Emre Ersin <emre.ersin@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 946 bytes --]

It has to be set before configure. Because configure script creates wrong
.h file.

On Sat, Mar 24, 2012 at 2:44 PM, Peter Maydell <peter.maydell@linaro.org>wrote:

> On 23 March 2012 20:05, Stefan Weil <sw@weilnetz.de> wrote:
> > +# Set default locale for commands like tr and others.
> > +LANG=C
> > +LC_ALL=C
> > +LC_CTYPE=C
>
> You don't export these, which leads to an obscure corner case:
> if the user has no LANG variable set in their environment when
> they run make then we will set LANG=C in the top level makefile
> but it will not be set in a sub-makefile. Since the default
> locale is the same as the C locale this doesn't make any
> practical difference, but it's a little odd.
>
> (Make automatically exports variables to submakes if they had
> some value in its environment when it was started, but not if
> they were only set in the makefile.)
>
> Also, do we need to set these in configure too?
>
> -- PMM
>



-- 
Emre Ersin

[-- Attachment #2: Type: text/html, Size: 1364 bytes --]