[Qemu-devel] [Bug 962880] [NEW] having a tr_TR.UTF-8 locale creates problems during compile

[Qemu-devel] [Bug 962880] [NEW] having a tr_TR.UTF-8 locale creates problems during compile

[Emre Ersin]

Public bug reported:

Default locale;

/opt/test/qemu-1.0.1# locale
LANG=tr_TR.UTF-8
LC_CTYPE="tr_TR.UTF-8"
...
LC_IDENTIFICATION="tr_TR.UTF-8"
LC_ALL=
------------------
./configure && make
.
.
.
/opt/test/qemu-1.0.1/vl.c: In function 'main':
/opt/test/qemu-1.0.1/vl.c:2248: hata: 'CONFIG_QEMU_CONFDIR' bildirilmemiş (bu işlevde ilk kullanımı)
/opt/test/qemu-1.0.1/vl.c:2248: hata: (Bildirilmemiş her betimleyici görüldüğü her işlev
/opt/test/qemu-1.0.1/vl.c:2248: hata: için sadece bir kez raporlanır.)
/opt/test/qemu-1.0.1/vl.c:2248: hata: expected ')' before string constant
/opt/test/qemu-1.0.1/vl.c:3090: hata: 'CONFIG_QEMU_DATADIR' bildirilmemiş (bu işlevde ilk kullanımı)
make[1]: *** [vl.o] Hata 1
make: *** [subdir-libhw64] Hata 2
------------------
if we examine the config-host.h (look at the "i" characters)

#define CONFIG_QEMU_PREFiX "/usr/local"
#define CONFIG_QEMU_BiNDiR "/usr/local/bin"
#define CONFIG_QEMU_LiBDiR "/usr/local/lib"
#define CONFIG_QEMU_iNCLUDEDiR "/usr/local/include"
#define CONFIG_QEMU_MANDiR "/usr/local/share/man"
#define CONFIG_QEMU_DATADiR "/usr/local/share/qemu"
#define CONFIG_QEMU_SYSCONFDiR "/usr/local/etc"
#define CONFIG_QEMU_DOCDiR "/usr/local/share/doc/qemu"
#define CONFIG_QEMU_CONFDiR "/usr/local/etc/qemu"
-------------------

changing LC_ALL and LC_LANG to POSIX (C) solves the problem.

** Affects: qemu
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/962880

Title:
  having a tr_TR.UTF-8 locale creates problems during compile

Status in QEMU:
  New

Bug description:
  Default locale;

  /opt/test/qemu-1.0.1# locale
  LANG=tr_TR.UTF-8
  LC_CTYPE="tr_TR.UTF-8"
  ...
  LC_IDENTIFICATION="tr_TR.UTF-8"
  LC_ALL=
  ------------------
  ./configure && make
  .
  .
  .
  /opt/test/qemu-1.0.1/vl.c: In function 'main':
  /opt/test/qemu-1.0.1/vl.c:2248: hata: 'CONFIG_QEMU_CONFDIR' bildirilmemiş (bu işlevde ilk kullanımı)
  /opt/test/qemu-1.0.1/vl.c:2248: hata: (Bildirilmemiş her betimleyici görüldüğü her işlev
  /opt/test/qemu-1.0.1/vl.c:2248: hata: için sadece bir kez raporlanır.)
  /opt/test/qemu-1.0.1/vl.c:2248: hata: expected ')' before string constant
  /opt/test/qemu-1.0.1/vl.c:3090: hata: 'CONFIG_QEMU_DATADIR' bildirilmemiş (bu işlevde ilk kullanımı)
  make[1]: *** [vl.o] Hata 1
  make: *** [subdir-libhw64] Hata 2
  ------------------
  if we examine the config-host.h (look at the "i" characters)

  #define CONFIG_QEMU_PREFiX "/usr/local"
  #define CONFIG_QEMU_BiNDiR "/usr/local/bin"
  #define CONFIG_QEMU_LiBDiR "/usr/local/lib"
  #define CONFIG_QEMU_iNCLUDEDiR "/usr/local/include"
  #define CONFIG_QEMU_MANDiR "/usr/local/share/man"
  #define CONFIG_QEMU_DATADiR "/usr/local/share/qemu"
  #define CONFIG_QEMU_SYSCONFDiR "/usr/local/etc"
  #define CONFIG_QEMU_DOCDiR "/usr/local/share/doc/qemu"
  #define CONFIG_QEMU_CONFDiR "/usr/local/etc/qemu"
  -------------------

  changing LC_ALL and LC_LANG to POSIX (C) solves the problem.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/962880/+subscriptions

[Qemu-devel] [PATCH] Makefile: Set default locale C

[Stefan Weil]

Some locale settings let make fail or create wrong results,
so set always the C locale.

* Conversion from lower to upper case with tr does not convert
  lower case 'i' to 'I' with locale tr_TR.UTF-8.

* The html files created from texi input contain non english
  titles like "Anhang" with locale de_DE.UTF-8.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 Makefile |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/Makefile b/Makefile
index 1bc3cb0..fef0d7f 100644
--- a/Makefile
+++ b/Makefile
@@ -37,6 +37,11 @@ $(call set-vpath, $(SRC_PATH):$(SRC_PATH)/hw)
 
 LIBS+=-lz $(LIBS_TOOLS)
 
+# Set default locale for commands like tr and others.
+LANG=C
+LC_ALL=C
+LC_CTYPE=C
+
 HELPERS-$(CONFIG_LINUX) = qemu-bridge-helper$(EXESUF)
 
 ifdef BUILD_DOCS
-- 
1.7.9

Re: [Qemu-devel] [PATCH] Makefile: Set default locale C

[Peter Maydell]

On 23 March 2012 20:05, Stefan Weil <sw@weilnetz.de> wrote:
> +# Set default locale for commands like tr and others.
> +LANG=C
> +LC_ALL=C
> +LC_CTYPE=C

You don't export these, which leads to an obscure corner case:
if the user has no LANG variable set in their environment when
they run make then we will set LANG=C in the top level makefile
but it will not be set in a sub-makefile. Since the default
locale is the same as the C locale this doesn't make any
practical difference, but it's a little odd.

(Make automatically exports variables to submakes if they had
some value in its environment when it was started, but not if
they were only set in the makefile.)

Also, do we need to set these in configure too?

-- PMM

Re: [Qemu-devel] [PATCH] Makefile: Set default locale C

[Emre Ersin]

[-- Attachment #1: Type: text/plain, Size: 946 bytes --]

It has to be set before configure. Because configure script creates wrong
.h file.

On Sat, Mar 24, 2012 at 2:44 PM, Peter Maydell <peter.maydell@linaro.org>wrote:

> On 23 March 2012 20:05, Stefan Weil <sw@weilnetz.de> wrote:
> > +# Set default locale for commands like tr and others.
> > +LANG=C
> > +LC_ALL=C
> > +LC_CTYPE=C
>
> You don't export these, which leads to an obscure corner case:
> if the user has no LANG variable set in their environment when
> they run make then we will set LANG=C in the top level makefile
> but it will not be set in a sub-makefile. Since the default
> locale is the same as the C locale this doesn't make any
> practical difference, but it's a little odd.
>
> (Make automatically exports variables to submakes if they had
> some value in its environment when it was started, but not if
> they were only set in the makefile.)
>
> Also, do we need to set these in configure too?
>
> -- PMM
>



-- 
Emre Ersin

[-- Attachment #2: Type: text/html, Size: 1364 bytes --]

Re: [Qemu-devel] [PATCH] Makefile: Set default locale C

[Stefan Weil]

[-- Attachment #1: Type: text/plain, Size: 1897 bytes --]

Am 24.03.2012 17:11, schrieb Emre Ersin:
> It has to be set before configure. Because configure script creates 
> wrong .h file.
>
> On Sat, Mar 24, 2012 at 2:44 PM, Peter Maydell 
> <peter.maydell@linaro.org <mailto:peter.maydell@linaro.org>> wrote:
>
>     On 23 March 2012 20:05, Stefan Weil <sw@weilnetz.de
>     <mailto:sw@weilnetz.de>> wrote:
>     > +# Set default locale for commands like tr and others.
>     > +LANG=C
>     > +LC_ALL=C
>     > +LC_CTYPE=C
>
>     You don't export these, which leads to an obscure corner case:
>     if the user has no LANG variable set in their environment when
>     they run make then we will set LANG=C in the top level makefile
>     but it will not be set in a sub-makefile. Since the default
>     locale is the same as the C locale this doesn't make any
>     practical difference, but it's a little odd.
>
>     (Make automatically exports variables to submakes if they had
>     some value in its environment when it was started, but not if
>     they were only set in the makefile.)
>
>     Also, do we need to set these in configure too?
>

Hi Peter,

yes, the same kind of patch is needed for configure, too.
I've already prepared one, but wanted to wait until this patch
was reviewed.

I intentionally did not add 'export' in the Makefile because up to now,
QEMU did not use this keyword in Makefiles, and I was not sure
whether it works on all build hosts with all variants of make.

I tested that my patch works. It's like you said: either the environment
variables are exported - then the settings in the Makefile override
the values and set the correct ones. Or they are not exported -
then the default setting is used which is also correct.

With my patch, configure creates a correct .h file.
There is no dependency on Makefile, so you have to remove the old
wrong .h file before running a new incremental build.

Regards,
Stefan W.


[-- Attachment #2: Type: text/html, Size: 3370 bytes --]

[Qemu-devel] [Bug 962880] Re: having a tr_TR.UTF-8 locale creates problems during compile

[Stefan Weil]

This should be fixed with the appended patch - please test.

** Changed in: qemu
     Assignee: (unassigned) => Stefan Weil (ubuntu-weilnetz)

** Patch added: "Always set locale C"
   https://bugs.launchpad.net/qemu/+bug/962880/+attachment/2924541/+files/0001-Makefile-Set-default-locale-C.patch

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/962880

Title:
  having a tr_TR.UTF-8 locale creates problems during compile

Status in QEMU:
  New

Bug description:
  Default locale;

  /opt/test/qemu-1.0.1# locale
  LANG=tr_TR.UTF-8
  LC_CTYPE="tr_TR.UTF-8"
  ...
  LC_IDENTIFICATION="tr_TR.UTF-8"
  LC_ALL=
  ------------------
  ./configure && make
  .
  .
  .
  /opt/test/qemu-1.0.1/vl.c: In function 'main':
  /opt/test/qemu-1.0.1/vl.c:2248: hata: 'CONFIG_QEMU_CONFDIR' bildirilmemiş (bu işlevde ilk kullanımı)
  /opt/test/qemu-1.0.1/vl.c:2248: hata: (Bildirilmemiş her betimleyici görüldüğü her işlev
  /opt/test/qemu-1.0.1/vl.c:2248: hata: için sadece bir kez raporlanır.)
  /opt/test/qemu-1.0.1/vl.c:2248: hata: expected ')' before string constant
  /opt/test/qemu-1.0.1/vl.c:3090: hata: 'CONFIG_QEMU_DATADIR' bildirilmemiş (bu işlevde ilk kullanımı)
  make[1]: *** [vl.o] Hata 1
  make: *** [subdir-libhw64] Hata 2
  ------------------
  if we examine the config-host.h (look at the "i" characters)

  #define CONFIG_QEMU_PREFiX "/usr/local"
  #define CONFIG_QEMU_BiNDiR "/usr/local/bin"
  #define CONFIG_QEMU_LiBDiR "/usr/local/lib"
  #define CONFIG_QEMU_iNCLUDEDiR "/usr/local/include"
  #define CONFIG_QEMU_MANDiR "/usr/local/share/man"
  #define CONFIG_QEMU_DATADiR "/usr/local/share/qemu"
  #define CONFIG_QEMU_SYSCONFDiR "/usr/local/etc"
  #define CONFIG_QEMU_DOCDiR "/usr/local/share/doc/qemu"
  #define CONFIG_QEMU_CONFDiR "/usr/local/etc/qemu"
  -------------------

  changing LC_ALL and LC_LANG to POSIX (C) solves the problem.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/962880/+subscriptions

[Qemu-devel] [Bug 962880] Re: having a tr_TR.UTF-8 locale creates problems during compile

[Stefan Weil]

** Patch added: "configure: Set default locale C (fix build	for Turkish locale)"
   https://bugs.launchpad.net/qemu/+bug/962880/+attachment/2936088/+files/0002-configure-Set-default-locale-C-fix-build-for-Turkish.patch

** Changed in: qemu
       Status: New => Confirmed

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/962880

Title:
  having a tr_TR.UTF-8 locale creates problems during compile

Status in QEMU:
  Confirmed

Bug description:
  Default locale;

  /opt/test/qemu-1.0.1# locale
  LANG=tr_TR.UTF-8
  LC_CTYPE="tr_TR.UTF-8"
  ...
  LC_IDENTIFICATION="tr_TR.UTF-8"
  LC_ALL=
  ------------------
  ./configure && make
  .
  .
  .
  /opt/test/qemu-1.0.1/vl.c: In function 'main':
  /opt/test/qemu-1.0.1/vl.c:2248: hata: 'CONFIG_QEMU_CONFDIR' bildirilmemiş (bu işlevde ilk kullanımı)
  /opt/test/qemu-1.0.1/vl.c:2248: hata: (Bildirilmemiş her betimleyici görüldüğü her işlev
  /opt/test/qemu-1.0.1/vl.c:2248: hata: için sadece bir kez raporlanır.)
  /opt/test/qemu-1.0.1/vl.c:2248: hata: expected ')' before string constant
  /opt/test/qemu-1.0.1/vl.c:3090: hata: 'CONFIG_QEMU_DATADIR' bildirilmemiş (bu işlevde ilk kullanımı)
  make[1]: *** [vl.o] Hata 1
  make: *** [subdir-libhw64] Hata 2
  ------------------
  if we examine the config-host.h (look at the "i" characters)

  #define CONFIG_QEMU_PREFiX "/usr/local"
  #define CONFIG_QEMU_BiNDiR "/usr/local/bin"
  #define CONFIG_QEMU_LiBDiR "/usr/local/lib"
  #define CONFIG_QEMU_iNCLUDEDiR "/usr/local/include"
  #define CONFIG_QEMU_MANDiR "/usr/local/share/man"
  #define CONFIG_QEMU_DATADiR "/usr/local/share/qemu"
  #define CONFIG_QEMU_SYSCONFDiR "/usr/local/etc"
  #define CONFIG_QEMU_DOCDiR "/usr/local/share/doc/qemu"
  #define CONFIG_QEMU_CONFDiR "/usr/local/etc/qemu"
  -------------------

  changing LC_ALL and LC_LANG to POSIX (C) solves the problem.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/962880/+subscriptions

[Qemu-devel] [Bug 962880] Re: having a tr_TR.UTF-8 locale creates problems during compile

[Stefan Weil]

This was fixed in git master with commit
bb55b712e8dc4d4eb515144d5c26798fea178cba.

** Changed in: qemu
       Status: Confirmed => Fix Committed

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/962880

Title:
  having a tr_TR.UTF-8 locale creates problems during compile

Status in QEMU:
  Fix Committed

Bug description:
  Default locale;

  /opt/test/qemu-1.0.1# locale
  LANG=tr_TR.UTF-8
  LC_CTYPE="tr_TR.UTF-8"
  ...
  LC_IDENTIFICATION="tr_TR.UTF-8"
  LC_ALL=
  ------------------
  ./configure && make
  .
  .
  .
  /opt/test/qemu-1.0.1/vl.c: In function 'main':
  /opt/test/qemu-1.0.1/vl.c:2248: hata: 'CONFIG_QEMU_CONFDIR' bildirilmemiş (bu işlevde ilk kullanımı)
  /opt/test/qemu-1.0.1/vl.c:2248: hata: (Bildirilmemiş her betimleyici görüldüğü her işlev
  /opt/test/qemu-1.0.1/vl.c:2248: hata: için sadece bir kez raporlanır.)
  /opt/test/qemu-1.0.1/vl.c:2248: hata: expected ')' before string constant
  /opt/test/qemu-1.0.1/vl.c:3090: hata: 'CONFIG_QEMU_DATADIR' bildirilmemiş (bu işlevde ilk kullanımı)
  make[1]: *** [vl.o] Hata 1
  make: *** [subdir-libhw64] Hata 2
  ------------------
  if we examine the config-host.h (look at the "i" characters)

  #define CONFIG_QEMU_PREFiX "/usr/local"
  #define CONFIG_QEMU_BiNDiR "/usr/local/bin"
  #define CONFIG_QEMU_LiBDiR "/usr/local/lib"
  #define CONFIG_QEMU_iNCLUDEDiR "/usr/local/include"
  #define CONFIG_QEMU_MANDiR "/usr/local/share/man"
  #define CONFIG_QEMU_DATADiR "/usr/local/share/qemu"
  #define CONFIG_QEMU_SYSCONFDiR "/usr/local/etc"
  #define CONFIG_QEMU_DOCDiR "/usr/local/share/doc/qemu"
  #define CONFIG_QEMU_CONFDiR "/usr/local/etc/qemu"
  -------------------

  changing LC_ALL and LC_LANG to POSIX (C) solves the problem.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/962880/+subscriptions

[Qemu-devel] [Bug 962880] Re: having a tr_TR.UTF-8 locale creates problems during compile

[Aurelien Jarno]

** Changed in: qemu
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/962880

Title:
  having a tr_TR.UTF-8 locale creates problems during compile

Status in QEMU:
  Fix Released

Bug description:
  Default locale;

  /opt/test/qemu-1.0.1# locale
  LANG=tr_TR.UTF-8
  LC_CTYPE="tr_TR.UTF-8"
  ...
  LC_IDENTIFICATION="tr_TR.UTF-8"
  LC_ALL=
  ------------------
  ./configure && make
  .
  .
  .
  /opt/test/qemu-1.0.1/vl.c: In function 'main':
  /opt/test/qemu-1.0.1/vl.c:2248: hata: 'CONFIG_QEMU_CONFDIR' bildirilmemiş (bu işlevde ilk kullanımı)
  /opt/test/qemu-1.0.1/vl.c:2248: hata: (Bildirilmemiş her betimleyici görüldüğü her işlev
  /opt/test/qemu-1.0.1/vl.c:2248: hata: için sadece bir kez raporlanır.)
  /opt/test/qemu-1.0.1/vl.c:2248: hata: expected ')' before string constant
  /opt/test/qemu-1.0.1/vl.c:3090: hata: 'CONFIG_QEMU_DATADIR' bildirilmemiş (bu işlevde ilk kullanımı)
  make[1]: *** [vl.o] Hata 1
  make: *** [subdir-libhw64] Hata 2
  ------------------
  if we examine the config-host.h (look at the "i" characters)

  #define CONFIG_QEMU_PREFiX "/usr/local"
  #define CONFIG_QEMU_BiNDiR "/usr/local/bin"
  #define CONFIG_QEMU_LiBDiR "/usr/local/lib"
  #define CONFIG_QEMU_iNCLUDEDiR "/usr/local/include"
  #define CONFIG_QEMU_MANDiR "/usr/local/share/man"
  #define CONFIG_QEMU_DATADiR "/usr/local/share/qemu"
  #define CONFIG_QEMU_SYSCONFDiR "/usr/local/etc"
  #define CONFIG_QEMU_DOCDiR "/usr/local/share/doc/qemu"
  #define CONFIG_QEMU_CONFDiR "/usr/local/etc/qemu"
  -------------------

  changing LC_ALL and LC_LANG to POSIX (C) solves the problem.

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/962880/+subscriptions