From: Christophe Lyon <christophe.lyon@linaro.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [Patch] v2 fix /proc/self/maps output
Date: Tue, 2 Apr 2013 14:03:38 +0200 [thread overview]
Message-ID: <CAKdteOYnrnY91NsuUKmoyMypRYK+aPs2t1ACJBPFK8pAXZTweA@mail.gmail.com> (raw)
Add a space at end of line when there is no filename to print, to
conform to linux kernel format (see show_map_vma() in
fs/proc/task_mmu.c).
Signed-off-by: Christophe Lyon <christophe.lyon@linaro.org>
---
Changes v1-v2:
Additional space is now part of the format string.
linux-user/syscall.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index a148d9f..c3c5c11 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -5013,10 +5013,10 @@ static int open_self_maps(void *cpu_env, int fd)
}
if (h2g_valid(min) && h2g_valid(max)) {
dprintf(fd, TARGET_ABI_FMT_lx "-" TARGET_ABI_FMT_lx
- " %c%c%c%c %08" PRIx64 " %02x:%02x %d%s%s\n",
+ " %c%c%c%c %08" PRIx64 " %02x:%02x %d %s%s\n",
h2g(min), h2g(max), flag_r, flag_w,
flag_x, flag_p, offset, dev_maj, dev_min, inode,
- path[0] ? " " : "", path);
+ path[0] ? " " : "", path);
}
}
--
1.7.10.4
next reply other threads:[~2013-04-02 12:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 12:03 Christophe Lyon [this message]
2013-05-05 21:01 ` [Qemu-devel] [Patch] v2 fix /proc/self/maps output Christophe Lyon
2013-05-05 21:11 ` Peter Maydell
2013-05-14 5:49 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKdteOYnrnY91NsuUKmoyMypRYK+aPs2t1ACJBPFK8pAXZTweA@mail.gmail.com \
--to=christophe.lyon@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).