From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BA2AC433F5 for ; Wed, 27 Oct 2021 15:58:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0F9F60E54 for ; Wed, 27 Oct 2021 15:58:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C0F9F60E54 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:57142 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mflJk-0007uv-SH for qemu-devel@archiver.kernel.org; Wed, 27 Oct 2021 11:58:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfkor-00042y-Td for qemu-devel@nongnu.org; Wed, 27 Oct 2021 11:26:25 -0400 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]:37420) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mfkop-0002SD-Ph for qemu-devel@nongnu.org; Wed, 27 Oct 2021 11:26:25 -0400 Received: by mail-lf1-x12b.google.com with SMTP id bp15so6986863lfb.4 for ; Wed, 27 Oct 2021 08:26:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ahZU4k0J/U5sRPBLSiZHxJ4JUNXjhmGoq7Cv288rrxc=; b=Kd/wZkjQXRrs1vKZ3N70DUu1XD+WJfwNYwf8rOFeEinIalaqwv8oApTWUPQFfvwu44 nafcHJLFzE1mBeLBFrR/ruEAI5aq8Ac9QQXpsvmf5mnQMUvb/JF8umGBEr8Fx+HQxt/i gL55jHw3nKcoPhUSo3z8W7OHobRYYpbWdox9ZMxfqdKao3JqHeMmYPGC1+yD2xghQA7F kqfTskkf8iwFyU/eh9cRc3HQGPyR8vWxHxOc/hID4rqSpZgzpQhDay2X99/aZ31AHniZ 3MXTwhMV1kZnHnOiVe/LL35/QTwCZJch4hHGJw/YKlyhuXHVBWp/3BjiJmwOgwahY7+a 9lnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ahZU4k0J/U5sRPBLSiZHxJ4JUNXjhmGoq7Cv288rrxc=; b=gAAssUF8BdpCP441z4g5JfjeYrcTFapSWKX7mRnzVJWp65+qFk3CIxzcZ1ZpAk/vhB In82zZoFh1HAINODymal/5pli/fp4GyjdUl97AjpvywdCCkw6yofENvurabN7w0BLBp/ mcyIQxuHB2GZDxb581cjrk41GPlh3hyNO0F6tXzynhhEIvbRon/h7ENuaYscFwDXb3H2 oy3k0+hAWXnoEjXB3B9CbHLdzxzrk3h73/v8GoTzdEuVHWOIH6QCSzli7RcnmDQg+JVO x97kcn4SvOzmkQShmCpPEIKaLZU5V4UwRScdTkCFn3G4MDoctptmrHaACBBqGXgr1jlr 9KDQ== X-Gm-Message-State: AOAM531Ifp2Qc0IaFziX92GkGPaczQWOEQ9/bH+9ptb/wLdDnrZCQG3x U6NpsbqNyBU5xg4ZO6tAmycGlbpCXf4h8iTgTpw= X-Google-Smtp-Source: ABdhPJyGYj6FPzSsWdIkYbesHZ65/Nk0Aw10Fxf/0PCOWKxCPYWIiHEx46odEdo0A4605p5nh2byEruljPxw++eeLkk= X-Received: by 2002:a05:6512:3ca3:: with SMTP id h35mr17503500lfv.128.1635348381246; Wed, 27 Oct 2021 08:26:21 -0700 (PDT) MIME-Version: 1.0 References: <20211027151012.2639284-1-imammedo@redhat.com> In-Reply-To: <20211027151012.2639284-1-imammedo@redhat.com> From: Jason Andryuk Date: Wed, 27 Oct 2021 11:26:09 -0400 Message-ID: Subject: Re: [PATCH v2] qtest: fix 'expression is always false' build failure in qtest_has_accel() To: Igor Mammedov Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::12b; envelope-from=jandryuk@gmail.com; helo=mail-lf1-x12b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , QEMU , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Oct 27, 2021 at 11:10 AM Igor Mammedov wrote: > > If KVM is disabled or not present, qtest library build > may fail with: > libqtest.c: In function 'qtest_has_accel': > comparison of unsigned expression < 0 is always false > [-Werror=type-limits] > for (i = 0; i < ARRAY_SIZE(targets); i++) { > > due to empty 'targets' array. > Fix it by making sure that CONFIG_KVM_TARGETS isn't empty. > > Fixes: e741aff0f43343 ("tests: qtest: add qtest_has_accel() to check if tested binary supports accelerator") > Reported-by: Jason Andryuk > Suggested-by: "Michael S. Tsirkin" > Signed-off-by: Igor Mammedov Tested-by: Jason Andryuk Thanks, Jason