From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47379)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <camm@ualberta.ca>) id 1TgTjM-0000cf-N4
	for qemu-devel@nongnu.org; Thu, 06 Dec 2012 00:10:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <camm@ualberta.ca>) id 1TgTjK-0007Fx-4U
	for qemu-devel@nongnu.org; Thu, 06 Dec 2012 00:10:40 -0500
Received: from mail-pb0-f45.google.com ([209.85.160.45]:42656)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <camm@ualberta.ca>) id 1TgTjJ-0007Eu-UT
	for qemu-devel@nongnu.org; Thu, 06 Dec 2012 00:10:38 -0500
Received: by mail-pb0-f45.google.com with SMTP id mc8so3948758pbc.4
	for <qemu-devel@nongnu.org>; Wed, 05 Dec 2012 21:10:35 -0800 (PST)
MIME-Version: 1.0
Sender: camm@ualberta.ca
In-Reply-To: <50BF0AE1.5010606@siemens.com>
References: <1353815517-319-1-git-send-email-qemulist@gmail.com>
	<1353815517-319-2-git-send-email-qemulist@gmail.com>
	<CAKjmthLpv42dAAbmtG4EbHu_QQ7=Qsf0qdiDCEsY4UC9SXrSpQ@mail.gmail.com>
	<50BF0AE1.5010606@siemens.com>
Date: Wed, 5 Dec 2012 22:10:35 -0700
Message-ID: <CAKjmthJGTcSEcf3A7xZ+e3S6bbaGF=wcRf6MF1oMUr57RP7w+w@mail.gmail.com>
From: Cam Macdonell <cam@cs.ualberta.ca>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCH v2 2/2] ivshmem: use irqfd to interrupt
	among VMs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Liu Ping Fan <qemulist@gmail.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On Wed, Dec 5, 2012 at 1:50 AM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> On 2012-12-05 06:34, Cam Macdonell wrote:
>>>  static void ivshmem_write_config(PCIDevice *pci_dev, uint32_t address,
>>>                                  uint32_t val, int len)
>>>  {
>>> +    bool is_enabled, was_enabled = msi_enabled(pci_dev);
>>> +
>>>      pci_default_write_config(pci_dev, address, val, len);
>>> +    is_enabled = msi_enabled(pci_dev);
>>
>> Problem 1)  in my tests is_enabled is always 0, so I don't think the
>> irqfds are getting setup
>
> You likely want to call msix_enabled here.

Yup, that gets it working.

Liu Ping, can you update the patch to use msix_enabled()?

Also, it seems that with irqfd enabled the user-level handlers are not
triggered, but it may still be a better idea to not add the user-level
handlers to the char devices at all if irqfd is enabled.

Cam

>
> Jan
>
> --
> Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
> Corporate Competence Center Embedded Linux
>