From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52505)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <camm@ualberta.ca>) id 1Tg7h9-0003re-Ep
	for qemu-devel@nongnu.org; Wed, 05 Dec 2012 00:38:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <camm@ualberta.ca>) id 1Tg7h6-0002k3-Up
	for qemu-devel@nongnu.org; Wed, 05 Dec 2012 00:38:55 -0500
Received: from mail-da0-f45.google.com ([209.85.210.45]:46534)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <camm@ualberta.ca>) id 1Tg7h6-0002jt-Od
	for qemu-devel@nongnu.org; Wed, 05 Dec 2012 00:38:52 -0500
Received: by mail-da0-f45.google.com with SMTP id w4so1962305dam.4
	for <qemu-devel@nongnu.org>; Tue, 04 Dec 2012 21:38:52 -0800 (PST)
MIME-Version: 1.0
Sender: camm@ualberta.ca
In-Reply-To: <1353815517-319-1-git-send-email-qemulist@gmail.com>
References: <1353815517-319-1-git-send-email-qemulist@gmail.com>
Date: Tue, 4 Dec 2012 22:38:51 -0700
Message-ID: <CAKjmthLiAE0Bz3Aic3vJsPrZyetMEBmiduz1Nx1R8CqoJgRTrQ@mail.gmail.com>
From: Cam Macdonell <cam@cs.ualberta.ca>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCH v2 1/2] ivshmem: remove msix_write_config
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Liu Ping Fan <qemulist@gmail.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org

On Sat, Nov 24, 2012 at 8:51 PM, Liu Ping Fan <qemulist@gmail.com> wrote:
> From: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
>
> This logic has been integrated into pci core, so remove it.
>
> Signed-off-by: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
Signed-off-by: Cam Macdonell <cam@cs.ualberta.ca>
> ---
>  hw/ivshmem.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/hw/ivshmem.c b/hw/ivshmem.c
> index f6dbb21..7c8630c 100644
> --- a/hw/ivshmem.c
> +++ b/hw/ivshmem.c
> @@ -629,7 +629,6 @@ static void ivshmem_write_config(PCIDevice *pci_dev, uint32_t address,
>                                  uint32_t val, int len)
>  {
>      pci_default_write_config(pci_dev, address, val, len);
> -    msix_write_config(pci_dev, address, val, len);
>  }
>
>  static int pci_ivshmem_init(PCIDevice *dev)
> --
> 1.7.4.4
>