From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46208) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aKEIH-0006d1-Ot for qemu-devel@nongnu.org; Fri, 15 Jan 2016 19:00:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aKEIG-0001yq-RT for qemu-devel@nongnu.org; Fri, 15 Jan 2016 19:00:37 -0500 Received: from mail-ob0-x242.google.com ([2607:f8b0:4003:c01::242]:36106) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aKEIG-0001ym-Mc for qemu-devel@nongnu.org; Fri, 15 Jan 2016 19:00:36 -0500 Received: by mail-ob0-x242.google.com with SMTP id is5so11183603obc.3 for ; Fri, 15 Jan 2016 16:00:36 -0800 (PST) MIME-Version: 1.0 Sender: alistair23@gmail.com In-Reply-To: References: From: Alistair Francis Date: Fri, 15 Jan 2016 16:00:06 -0800 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v7 1/6] qdev: get_child_bus(): Use QOM lookup if available List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: Peter Maydell , "qemu-devel@nongnu.org Developers" , Alistair Francis On Fri, Jan 15, 2016 at 2:47 PM, Peter Crosthwaite wrote: > On Fri, Jan 15, 2016 at 2:38 PM, Alistair Francis > wrote: >> From: Peter Crosthwaite >> >> qbus_realize() adds busses as a QOM child of the device in addition to >> adding it to the qdev bus list. Change get_child_bus() to use the QOM >> child if it is available. This takes priority over the bus-list, but >> the child object is checked for type correctness. >> >> This prepares support for aliasing of buses. The use case is SoCs, >> where a SoC container needs to present buses to the board level, but >> the buses are implemented by controller IP we already model as self >> contained qbus-containing devices. >> >> Signed-off-by: Peter Crosthwaite >> Acked-by: Alistair Francis > > As a re-sender, you need to Signed-off-by as well. I'm guessing you > can just do this on list like a review to avoid the respin. Ok, here it is: Signed-off-by: Alistair Francis Thanks, Alistair