From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DF2ECCD187 for ; Tue, 14 Oct 2025 05:19:41 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v8XRG-0002W3-QL; Tue, 14 Oct 2025 01:19:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v8XRF-0002Uy-1u for qemu-devel@nongnu.org; Tue, 14 Oct 2025 01:19:09 -0400 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v8XRC-0005Od-7W for qemu-devel@nongnu.org; Tue, 14 Oct 2025 01:19:08 -0400 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-62fca01f0d9so10076635a12.3 for ; Mon, 13 Oct 2025 22:19:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760419143; x=1761023943; darn=nongnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZAlk7T6TK2p+DpULEo0NtxKk/ZIZl2cy2Hvke0k38nE=; b=cqdLeJtj6gj60ocHyYPYyHcwfab5M1TCI142WoVPyNAqwSu2g/4AhqjJ6hRRR9vKe7 y1d5ZHmavaGy8yQ8YFHR07uxE8jHxfY0Wui/XymdODRTMyBWmoc3At1HsCNr4HUW81Bw lnVfnT8YDcFnUVdo6niLpaBntM33bgbLRXA11/0x12NP1db0Ev0k/XC8+jhVGCc5dcC1 sZ3NCjEkaW57eyR05ANR+/dkMu8xXrO1HOGx3gKN4vjHUgaNJaMcAbFnYuPTJasqxe3s +x3d8+1QAGCiFtB4qGkUpeahJglMTX7m+SoaSPj2385g6nIhZOmuXxh1FCHHgQTKnjJV t/8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760419143; x=1761023943; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZAlk7T6TK2p+DpULEo0NtxKk/ZIZl2cy2Hvke0k38nE=; b=O+gs5NRZrhQtKmDOmIks9G1NlqAjMdxDRMqmPHiqbU12j+IoX16V32JiGXFzMTygx6 BfL5+4t1BQOUTa6p/4766RsaiDX6H7N37SG6yXyVwujuDTZz8BWsm6HhiDO5tnZTXhx1 9g+Ss+QX40/ZVemokbdrH7tdJAx4M5Fp5oJGwnC8uDp7cOekBxwFy3s6WZqM3j8rR64v Mm4fbXaRxMac9TC/OH1IyT8aklJsdCBsrtPvBGrJnF+58FgTsoo6t61ayn0LTkkl7F1I /ehDtxULqREu5jS0aqe8K5yhkN9L/KcSzGA6KDOU2B/Vs6x+jMCyez8N3cXYyfEc7vfv VjQQ== X-Gm-Message-State: AOJu0YzW3aVZZDkXSlr3yfkA1GaPL9dh284RiB+C8cOgset+MLlZh9Sp vOPcAMVBPyar1nnvj0kUeS566bAMXQVJmmnPX+cxoMzP9z8urfo4djkSaPw6UP0pwD8hwPEXoeA DcGA3dRbgxwH9ZiiBuXypAZBeSdz6EAs= X-Gm-Gg: ASbGnct3MZ/ylN/1IlSCmSDk8xeSzvvTQTt+YLMyJEOi7nnTHSFuOWU+hO9tzAYBUg9 hA2aH6SSGTtBcfWB36eOchEdsaZWnyvGhBO/DoJN88SiJdYgQOt1GOMUBZOgD0XucsDYW87VxpI IVaGH4CvgsYKpDFTVBiPPWVHttz3CvKQWWYbasj6wF/J5cTTrhy0zuUeY8KNZpnuFSiGhnBCxKr sFwCP4DcHFy8il+ZselgO6OYDINinnSz6LKKZILAjRdGfyaxOgZCjAxP8t/8qY6d2M= X-Google-Smtp-Source: AGHT+IGV79/HDVEqu1oh+LwrazhIGg2jJTrJH/TszM1bqSwYgSmGNjr5GmriSxInUIugojyHJu//tdcZTiM9vyrRpRc= X-Received: by 2002:a05:6402:1469:b0:639:ffd6:993b with SMTP id 4fb4d7f45d1cf-639ffd6a393mr17024089a12.16.1760419143498; Mon, 13 Oct 2025 22:19:03 -0700 (PDT) MIME-Version: 1.0 References: <20251010134226.72221-1-philmd@linaro.org> <20251010134226.72221-7-philmd@linaro.org> In-Reply-To: <20251010134226.72221-7-philmd@linaro.org> From: Alistair Francis Date: Tue, 14 Oct 2025 15:18:37 +1000 X-Gm-Features: AS18NWCjCT2NUdXpwcdshncS05aqvBaiKkJbnAAsctvuvEFFjLEiu-TySDv6H4c Message-ID: Subject: Re: [PATCH 06/16] hw/core/loader: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::52a; envelope-from=alistair23@gmail.com; helo=mail-ed1-x52a.google.com X-Spam_score_int: 7 X-Spam_score: 0.7 X-Spam_bar: / X-Spam_report: (0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, SUSPICIOUS_RECIPS=2.51 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Oct 10, 2025 at 11:46=E2=80=AFPM Philippe Mathieu-Daud=C3=A9 wrote: > > Replace compile-time #ifdef with a runtime check to ensure all code > paths are built and tested. This reduces build-time configuration > complexity and improves maintainability. > > No functional change intended. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Alistair > --- > hw/core/loader.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/hw/core/loader.c b/hw/core/loader.c > index 477661a0255..aef10cb3f2b 100644 > --- a/hw/core/loader.c > +++ b/hw/core/loader.c > @@ -491,7 +491,9 @@ ssize_t load_elf_ram_sym(const char *filename, > > static void bswap_uboot_header(uboot_image_header_t *hdr) > { > -#if !HOST_BIG_ENDIAN > + if (HOST_BIG_ENDIAN) { > + return; > + } > bswap32s(&hdr->ih_magic); > bswap32s(&hdr->ih_hcrc); > bswap32s(&hdr->ih_time); > @@ -499,7 +501,6 @@ static void bswap_uboot_header(uboot_image_header_t *= hdr) > bswap32s(&hdr->ih_load); > bswap32s(&hdr->ih_ep); > bswap32s(&hdr->ih_dcrc); > -#endif > } > > > -- > 2.51.0 > >