From: Alistair Francis <alistair23@gmail.com>
To: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org,
alistair.francis@wdc.com, bmeng@tinylab.org,
liweiwei@iscas.ac.cn, zhiwei_liu@linux.alibaba.com,
palmer@rivosinc.com,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH v6 4/9] target/riscv: add PRIV_VERSION_LATEST
Date: Thu, 6 Apr 2023 12:06:54 +1000 [thread overview]
Message-ID: <CAKmqyKMHBJphVYovJ4Gzi2FGKAZGwXGR7SGFny_z-KFOU0bALQ@mail.gmail.com> (raw)
In-Reply-To: <20230329200856.658733-5-dbarboza@ventanamicro.com>
On Thu, Mar 30, 2023 at 6:11 AM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:
>
> All these generic CPUs are using the latest priv available, at this
> moment PRIV_VERSION_1_12_0:
>
> - riscv_any_cpu_init()
> - rv32_base_cpu_init()
> - rv64_base_cpu_init()
> - rv128_base_cpu_init()
>
> Create a new PRIV_VERSION_LATEST enum and use it in those cases. I'll
> make it easier to update everything at once when a new priv version is
> available.
>
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
> Reviewed-by: Weiwei Li <liweiwei@iscas.ac.cn>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/riscv/cpu.c | 8 ++++----
> target/riscv/cpu.h | 2 ++
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index 75c3d4ed22..1743e9ede3 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -338,7 +338,7 @@ static void riscv_any_cpu_init(Object *obj)
> VM_1_10_SV32 : VM_1_10_SV57);
> #endif
>
> - env->priv_ver = PRIV_VERSION_1_12_0;
> + env->priv_ver = PRIV_VERSION_LATEST;
> }
>
> #if defined(TARGET_RISCV64)
> @@ -349,7 +349,7 @@ static void rv64_base_cpu_init(Object *obj)
> set_misa(env, MXL_RV64, 0);
> riscv_cpu_add_user_properties(obj);
> /* Set latest version of privileged specification */
> - env->priv_ver = PRIV_VERSION_1_12_0;
> + env->priv_ver = PRIV_VERSION_LATEST;
> #ifndef CONFIG_USER_ONLY
> set_satp_mode_max_supported(RISCV_CPU(obj), VM_1_10_SV57);
> #endif
> @@ -418,7 +418,7 @@ static void rv128_base_cpu_init(Object *obj)
> set_misa(env, MXL_RV128, 0);
> riscv_cpu_add_user_properties(obj);
> /* Set latest version of privileged specification */
> - env->priv_ver = PRIV_VERSION_1_12_0;
> + env->priv_ver = PRIV_VERSION_LATEST;
> #ifndef CONFIG_USER_ONLY
> set_satp_mode_max_supported(RISCV_CPU(obj), VM_1_10_SV57);
> #endif
> @@ -431,7 +431,7 @@ static void rv32_base_cpu_init(Object *obj)
> set_misa(env, MXL_RV32, 0);
> riscv_cpu_add_user_properties(obj);
> /* Set latest version of privileged specification */
> - env->priv_ver = PRIV_VERSION_1_12_0;
> + env->priv_ver = PRIV_VERSION_LATEST;
> #ifndef CONFIG_USER_ONLY
> set_satp_mode_max_supported(RISCV_CPU(obj), VM_1_10_SV32);
> #endif
> diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
> index 02f26130d5..03b5cc2cf4 100644
> --- a/target/riscv/cpu.h
> +++ b/target/riscv/cpu.h
> @@ -86,6 +86,8 @@ enum {
> PRIV_VERSION_1_10_0 = 0,
> PRIV_VERSION_1_11_0,
> PRIV_VERSION_1_12_0,
> +
> + PRIV_VERSION_LATEST = PRIV_VERSION_1_12_0,
> };
>
> #define VEXT_VERSION_1_00_0 0x00010000
> --
> 2.39.2
>
>
next prev parent reply other threads:[~2023-04-06 2:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 20:08 [PATCH v6 0/9] target/riscv: rework CPU extensions validation Daniel Henrique Barboza
2023-03-29 20:08 ` [PATCH v6 1/9] target/riscv/cpu.c: add riscv_cpu_validate_v() Daniel Henrique Barboza
2023-04-06 1:59 ` Alistair Francis
2023-03-29 20:08 ` [PATCH v6 2/9] target/riscv/cpu.c: remove set_vext_version() Daniel Henrique Barboza
2023-04-06 2:00 ` Alistair Francis
2023-03-29 20:08 ` [PATCH v6 3/9] target/riscv/cpu.c: remove set_priv_version() Daniel Henrique Barboza
2023-04-06 2:05 ` Alistair Francis
2023-03-29 20:08 ` [PATCH v6 4/9] target/riscv: add PRIV_VERSION_LATEST Daniel Henrique Barboza
2023-04-06 2:06 ` Alistair Francis [this message]
2023-03-29 20:08 ` [PATCH v6 5/9] target/riscv/cpu.c: add priv_spec validate/disable_exts helpers Daniel Henrique Barboza
2023-04-06 2:08 ` Alistair Francis
2023-03-29 20:08 ` [PATCH v6 6/9] target/riscv/cpu.c: add riscv_cpu_validate_misa_mxl() Daniel Henrique Barboza
2023-04-06 2:09 ` Alistair Francis
2023-03-29 20:08 ` [PATCH v6 7/9] target/riscv/cpu.c: validate extensions before riscv_timer_init() Daniel Henrique Barboza
2023-04-06 2:10 ` Alistair Francis
2023-03-29 20:08 ` [PATCH v6 8/9] target/riscv/cpu.c: remove cfg setup from riscv_cpu_init() Daniel Henrique Barboza
2023-04-06 2:12 ` Alistair Francis
2023-03-29 20:08 ` [PATCH v6 9/9] target/riscv: rework write_misa() Daniel Henrique Barboza
2023-03-29 20:12 ` [PATCH v6 0/9] target/riscv: rework CPU extensions validation Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKmqyKMHBJphVYovJ4Gzi2FGKAZGwXGR7SGFny_z-KFOU0bALQ@mail.gmail.com \
--to=alistair23@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=bmeng@tinylab.org \
--cc=dbarboza@ventanamicro.com \
--cc=liweiwei@iscas.ac.cn \
--cc=palmer@rivosinc.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).