Re: [PATCH 4/7] hw/core/register: remove the `register_finalize_block' function

[Alistair Francis <alistair23@gmail.com>]

On Wed, Sep 17, 2025 at 9:50 PM Luc Michel <luc.michel@amd.com> wrote:
>
> This function is now unused. Drop it.
>
> Signed-off-by: Luc Michel <luc.michel@amd.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  include/hw/register.h | 14 --------------
>  hw/core/register.c    |  4 ----
>  2 files changed, 18 deletions(-)
>
> diff --git a/include/hw/register.h b/include/hw/register.h
> index 65c82600e06..7b0f4c8b7a6 100644
> --- a/include/hw/register.h
> +++ b/include/hw/register.h
> @@ -207,20 +207,6 @@ RegisterInfoArray *register_init_block64(DeviceState *owner,
>                                           uint64_t *data,
>                                           const MemoryRegionOps *ops,
>                                           bool debug_enabled,
>                                           uint64_t memory_size);
>
> -/**
> - * This function should be called to cleanup the registers that were initialized
> - * when calling register_init_block32(). This function should only be called
> - * from the device's instance_finalize function.
> - *
> - * Any memory operations that the device performed that require cleanup (such
> - * as creating subregions) need to be called before calling this function.
> - *
> - * @r_array: A structure containing all of the registers, as returned by
> - *           register_init_block32()
> - */
> -
> -void register_finalize_block(RegisterInfoArray *r_array);
> -
>  #endif
> diff --git a/hw/core/register.c b/hw/core/register.c
> index 4d1cce02a55..6cfcfcd2b14 100644
> --- a/hw/core/register.c
> +++ b/hw/core/register.c
> @@ -321,14 +321,10 @@ static void register_array_finalize(Object *obj)
>
>      object_unparent(OBJECT(&r_array->mem));
>      g_free(r_array->r);
>  }
>
> -void register_finalize_block(RegisterInfoArray *r_array)
> -{
> -}
> -
>  static const TypeInfo register_array_info = {
>      .name  = TYPE_REGISTER_ARRAY,
>      .parent = TYPE_OBJECT,
>      .instance_size = sizeof(RegisterInfoArray),
>      .instance_finalize = register_array_finalize,
> --
> 2.50.1
>
>