From: Alistair Francis <alistair23@gmail.com>
To: Bin Meng <bmeng.cn@gmail.com>
Cc: "open list:RISC-V" <qemu-riscv@nongnu.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alistair Francis <alistair.francis@wdc.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v2 5/8] target/riscv: Implementation of enhanced PMP (ePMP)
Date: Sun, 11 Apr 2021 00:06:09 -0400 [thread overview]
Message-ID: <CAKmqyKMaL8FA3EMsRB2=ujSj5JMpxZ_yn5sn1q3v9JsF+8Rbng@mail.gmail.com> (raw)
In-Reply-To: <CAEUhbmWgOcma-uHBU0Zb8BhDpvt6D06Qg1_ACNzGGzXV_L=MBw@mail.gmail.com>
On Fri, Apr 9, 2021 at 10:33 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> Hi Alistair,
>
> On Fri, Apr 9, 2021 at 8:23 PM Alistair Francis
> <alistair.francis@wdc.com> wrote:
> >
> > From: Hou Weiying <weiying_hou@outlook.com>
> >
> > This commit adds support for ePMP v0.9.1.
> >
> > The ePMP spec can be found in:
> > https://docs.google.com/document/d/1Mh_aiHYxemL0umN3GTTw8vsbmzHZ_nxZXgjgOUzbvc8
> >
> > Signed-off-by: Hongzheng-Li <Ethan.Lee.QNL@gmail.com>
> > Signed-off-by: Hou Weiying <weiying_hou@outlook.com>
> > Signed-off-by: Myriad-Dreamin <camiyoru@gmail.com>
> > Message-Id: <SG2PR02MB263462CCDBCBBAD36983C2CD93450@SG2PR02MB2634.apcprd02.prod.outlook.com>
> > [ Changes by AF:
> > - Rebase on master
> > - Update to latest spec
> > - Use a switch case to handle ePMP MML permissions
> > - Fix a few bugs
> > ]
> > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> > ---
> > target/riscv/pmp.c | 165 +++++++++++++++++++++++++++++++++++++++++----
> > 1 file changed, 153 insertions(+), 12 deletions(-)
> >
>
> It looks like the v1 comments are not addressed?
You are right. I sent this before I saw your comments for v1. I will
address those comments in a v3. Sorry about that.
Alistair
>
> Regards,
> Bin
next prev parent reply other threads:[~2021-04-11 4:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 12:19 [PATCH v2 0/8] RISC-V: Add support for ePMP v0.9.1 Alistair Francis
2021-04-09 12:19 ` [PATCH v2 1/8] target/riscv: Fix the PMP is locked check when using TOR Alistair Francis
2021-04-09 12:20 ` [PATCH v2 2/8] target/riscv: Define ePMP mseccfg Alistair Francis
2021-04-09 12:20 ` [PATCH v2 3/8] target/riscv: Add the ePMP feature Alistair Francis
2021-04-09 12:20 ` [PATCH v2 4/8] target/riscv: Add ePMP CSR access functions Alistair Francis
2021-04-09 12:20 ` [PATCH v2 5/8] target/riscv: Implementation of enhanced PMP (ePMP) Alistair Francis
2021-04-09 14:33 ` Bin Meng
2021-04-11 4:06 ` Alistair Francis [this message]
2021-04-09 12:20 ` [PATCH v2 6/8] target/riscv: Add a config option for ePMP Alistair Francis
2021-04-09 12:20 ` [PATCH v2 7/8] target/riscv/pmp: Remove outdated comment Alistair Francis
2021-04-09 12:20 ` [PATCH v2 8/8] target/riscv: Add ePMP support for the Ibex CPU Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKmqyKMaL8FA3EMsRB2=ujSj5JMpxZ_yn5sn1q3v9JsF+8Rbng@mail.gmail.com' \
--to=alistair23@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=bmeng.cn@gmail.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).