* [PATCH 2/3] hw/char: shakti_uart: Register device in 'input' category
2021-09-26 10:50 [PATCH 1/3] hw/char: ibex_uart: Register device in 'input' category Bin Meng
@ 2021-09-26 10:50 ` Bin Meng
2021-09-26 14:40 ` Philippe Mathieu-Daudé
2021-09-28 6:54 ` Alistair Francis
2021-09-26 10:50 ` [PATCH 3/3] hw/char: sifive_uart: " Bin Meng
` (2 subsequent siblings)
3 siblings, 2 replies; 10+ messages in thread
From: Bin Meng @ 2021-09-26 10:50 UTC (permalink / raw)
To: Alistair Francis, qemu-devel, qemu-riscv; +Cc: Philippe Mathieu-Daudé
The category of shakti_uart device is not set. Put it into the
'input' category.
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
hw/char/shakti_uart.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/char/shakti_uart.c b/hw/char/shakti_uart.c
index 6870821325..98b142c7df 100644
--- a/hw/char/shakti_uart.c
+++ b/hw/char/shakti_uart.c
@@ -168,6 +168,7 @@ static void shakti_uart_class_init(ObjectClass *klass, void *data)
dc->reset = shakti_uart_reset;
dc->realize = shakti_uart_realize;
device_class_set_props(dc, shakti_uart_properties);
+ set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
}
static const TypeInfo shakti_uart_info = {
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 2/3] hw/char: shakti_uart: Register device in 'input' category
2021-09-26 10:50 ` [PATCH 2/3] hw/char: shakti_uart: " Bin Meng
@ 2021-09-26 14:40 ` Philippe Mathieu-Daudé
2021-09-28 6:54 ` Alistair Francis
1 sibling, 0 replies; 10+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-09-26 14:40 UTC (permalink / raw)
To: Bin Meng, Alistair Francis, qemu-devel, qemu-riscv
On 9/26/21 12:50, Bin Meng wrote:
> The category of shakti_uart device is not set. Put it into the
> 'input' category.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> hw/char/shakti_uart.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] hw/char: shakti_uart: Register device in 'input' category
2021-09-26 10:50 ` [PATCH 2/3] hw/char: shakti_uart: " Bin Meng
2021-09-26 14:40 ` Philippe Mathieu-Daudé
@ 2021-09-28 6:54 ` Alistair Francis
1 sibling, 0 replies; 10+ messages in thread
From: Alistair Francis @ 2021-09-28 6:54 UTC (permalink / raw)
To: Bin Meng
Cc: open list:RISC-V, Alistair Francis,
qemu-devel@nongnu.org Developers, Philippe Mathieu-Daudé
On Sun, Sep 26, 2021 at 8:56 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> The category of shakti_uart device is not set. Put it into the
> 'input' category.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
>
> hw/char/shakti_uart.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/char/shakti_uart.c b/hw/char/shakti_uart.c
> index 6870821325..98b142c7df 100644
> --- a/hw/char/shakti_uart.c
> +++ b/hw/char/shakti_uart.c
> @@ -168,6 +168,7 @@ static void shakti_uart_class_init(ObjectClass *klass, void *data)
> dc->reset = shakti_uart_reset;
> dc->realize = shakti_uart_realize;
> device_class_set_props(dc, shakti_uart_properties);
> + set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
> }
>
> static const TypeInfo shakti_uart_info = {
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/3] hw/char: sifive_uart: Register device in 'input' category
2021-09-26 10:50 [PATCH 1/3] hw/char: ibex_uart: Register device in 'input' category Bin Meng
2021-09-26 10:50 ` [PATCH 2/3] hw/char: shakti_uart: " Bin Meng
@ 2021-09-26 10:50 ` Bin Meng
2021-09-26 14:40 ` Philippe Mathieu-Daudé
` (2 more replies)
2021-09-26 14:40 ` [PATCH 1/3] hw/char: ibex_uart: " Philippe Mathieu-Daudé
2021-09-28 6:52 ` Alistair Francis
3 siblings, 3 replies; 10+ messages in thread
From: Bin Meng @ 2021-09-26 10:50 UTC (permalink / raw)
To: Alistair Francis, qemu-devel, qemu-riscv; +Cc: Philippe Mathieu-Daudé
The category of sifive_uart device is not set. Put it into the
'input' category.
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
hw/char/sifive_uart.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c
index 278e21c434..1c75f792b3 100644
--- a/hw/char/sifive_uart.c
+++ b/hw/char/sifive_uart.c
@@ -248,6 +248,7 @@ static void sifive_uart_class_init(ObjectClass *oc, void *data)
rc->phases.enter = sifive_uart_reset_enter;
rc->phases.hold = sifive_uart_reset_hold;
device_class_set_props(dc, sifive_uart_properties);
+ set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
}
static const TypeInfo sifive_uart_info = {
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 3/3] hw/char: sifive_uart: Register device in 'input' category
2021-09-26 10:50 ` [PATCH 3/3] hw/char: sifive_uart: " Bin Meng
@ 2021-09-26 14:40 ` Philippe Mathieu-Daudé
2021-09-28 6:54 ` Alistair Francis
2021-09-28 9:18 ` Alistair Francis
2 siblings, 0 replies; 10+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-09-26 14:40 UTC (permalink / raw)
To: Bin Meng, Alistair Francis, qemu-devel, qemu-riscv
On 9/26/21 12:50, Bin Meng wrote:
> The category of sifive_uart device is not set. Put it into the
> 'input' category.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> hw/char/sifive_uart.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] hw/char: sifive_uart: Register device in 'input' category
2021-09-26 10:50 ` [PATCH 3/3] hw/char: sifive_uart: " Bin Meng
2021-09-26 14:40 ` Philippe Mathieu-Daudé
@ 2021-09-28 6:54 ` Alistair Francis
2021-09-28 9:18 ` Alistair Francis
2 siblings, 0 replies; 10+ messages in thread
From: Alistair Francis @ 2021-09-28 6:54 UTC (permalink / raw)
To: Bin Meng
Cc: open list:RISC-V, Alistair Francis,
qemu-devel@nongnu.org Developers, Philippe Mathieu-Daudé
On Sun, Sep 26, 2021 at 8:53 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> The category of sifive_uart device is not set. Put it into the
> 'input' category.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
>
> hw/char/sifive_uart.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c
> index 278e21c434..1c75f792b3 100644
> --- a/hw/char/sifive_uart.c
> +++ b/hw/char/sifive_uart.c
> @@ -248,6 +248,7 @@ static void sifive_uart_class_init(ObjectClass *oc, void *data)
> rc->phases.enter = sifive_uart_reset_enter;
> rc->phases.hold = sifive_uart_reset_hold;
> device_class_set_props(dc, sifive_uart_properties);
> + set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
> }
>
> static const TypeInfo sifive_uart_info = {
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 3/3] hw/char: sifive_uart: Register device in 'input' category
2021-09-26 10:50 ` [PATCH 3/3] hw/char: sifive_uart: " Bin Meng
2021-09-26 14:40 ` Philippe Mathieu-Daudé
2021-09-28 6:54 ` Alistair Francis
@ 2021-09-28 9:18 ` Alistair Francis
2 siblings, 0 replies; 10+ messages in thread
From: Alistair Francis @ 2021-09-28 9:18 UTC (permalink / raw)
To: Bin Meng
Cc: open list:RISC-V, Alistair Francis,
qemu-devel@nongnu.org Developers, Philippe Mathieu-Daudé
On Sun, Sep 26, 2021 at 8:53 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> The category of sifive_uart device is not set. Put it into the
> 'input' category.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Thanks!
Applied to riscv-to-apply.next
Alistair
> ---
>
> hw/char/sifive_uart.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c
> index 278e21c434..1c75f792b3 100644
> --- a/hw/char/sifive_uart.c
> +++ b/hw/char/sifive_uart.c
> @@ -248,6 +248,7 @@ static void sifive_uart_class_init(ObjectClass *oc, void *data)
> rc->phases.enter = sifive_uart_reset_enter;
> rc->phases.hold = sifive_uart_reset_hold;
> device_class_set_props(dc, sifive_uart_properties);
> + set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
> }
>
> static const TypeInfo sifive_uart_info = {
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] hw/char: ibex_uart: Register device in 'input' category
2021-09-26 10:50 [PATCH 1/3] hw/char: ibex_uart: Register device in 'input' category Bin Meng
2021-09-26 10:50 ` [PATCH 2/3] hw/char: shakti_uart: " Bin Meng
2021-09-26 10:50 ` [PATCH 3/3] hw/char: sifive_uart: " Bin Meng
@ 2021-09-26 14:40 ` Philippe Mathieu-Daudé
2021-09-28 6:52 ` Alistair Francis
3 siblings, 0 replies; 10+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-09-26 14:40 UTC (permalink / raw)
To: Bin Meng, Alistair Francis, qemu-devel, qemu-riscv; +Cc: Thomas Huth
On 9/26/21 12:50, Bin Meng wrote:
> The category of ibex_uart device is not set. Put it into the
> 'input' category.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
>
> hw/char/ibex_uart.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/char/ibex_uart.c b/hw/char/ibex_uart.c
> index 9b0a817713..e58181fcf4 100644
> --- a/hw/char/ibex_uart.c
> +++ b/hw/char/ibex_uart.c
> @@ -550,6 +550,7 @@ static void ibex_uart_class_init(ObjectClass *klass, void *data)
> dc->realize = ibex_uart_realize;
> dc->vmsd = &vmstate_ibex_uart;
> device_class_set_props(dc, ibex_uart_properties);
> + set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
> }
A bit orthogonal but I wonder if ADC (to the extent sensors)
and touch devices should be categorized as "input" ones.
Maybe we deserve a DEVICE_CATEGORY_SENSOR category?
Back to this patch:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
But it would be nice to have a generic way to avoid adding
uncategorized user-creatable devices.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] hw/char: ibex_uart: Register device in 'input' category
2021-09-26 10:50 [PATCH 1/3] hw/char: ibex_uart: Register device in 'input' category Bin Meng
` (2 preceding siblings ...)
2021-09-26 14:40 ` [PATCH 1/3] hw/char: ibex_uart: " Philippe Mathieu-Daudé
@ 2021-09-28 6:52 ` Alistair Francis
3 siblings, 0 replies; 10+ messages in thread
From: Alistair Francis @ 2021-09-28 6:52 UTC (permalink / raw)
To: Bin Meng
Cc: open list:RISC-V, Alistair Francis,
qemu-devel@nongnu.org Developers, Philippe Mathieu-Daudé
On Sun, Sep 26, 2021 at 8:51 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> The category of ibex_uart device is not set. Put it into the
> 'input' category.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
>
> hw/char/ibex_uart.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/char/ibex_uart.c b/hw/char/ibex_uart.c
> index 9b0a817713..e58181fcf4 100644
> --- a/hw/char/ibex_uart.c
> +++ b/hw/char/ibex_uart.c
> @@ -550,6 +550,7 @@ static void ibex_uart_class_init(ObjectClass *klass, void *data)
> dc->realize = ibex_uart_realize;
> dc->vmsd = &vmstate_ibex_uart;
> device_class_set_props(dc, ibex_uart_properties);
> + set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
> }
>
> static const TypeInfo ibex_uart_info = {
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread