Re: [Qemu-devel] [PATCH v1 2/2] generic-loader: Add a generic loader

[Alistair Francis <alistair.francis@xilinx.com>]

On Wed, Feb 17, 2016 at 4:11 PM, Eric Blake <eblake@redhat.com> wrote:
> On 02/17/2016 05:03 PM, Alistair Francis wrote:
>
>>>> +++ b/hw/misc/generic-loader.c
>>>> @@ -0,0 +1,127 @@
>>>> +/*
>>>> + * Generic Loader
>>>> + *
>>>> + * Copyright (C) 2014 Li Guang
>>>> + * Written by Li Guang <lig.fnst@cn.fujitsu.com>
>>>
>>> Want to claim 2016?
>>
>> Yep, I can do that. I'm never too sure when this can be changed or
>> not. Should I add a written by as well?
>
> I'm not a lawyer, so my response may not be authoritative; in
> particular, your employer may have specific rules that you must follow
> for any code you submit that was written on your employer's time, and
> that trumps anything I say here (that is, trust your lawyers more than
> you trust me).
>
> But in general, I tend to go by the simple rule of listing the first
> year that any of the code was first developed (if you are copying
> significant portions from some other file, then use the starting year
> from that file, even if your file didn't exist back then), through the
> current year, if my change is non-trivial (more than 10 lines, or
> altering an interface), while ignoring the issue for trivial things
> (such as fixing a typo, or doing a bulk search-and-replace across the
> tree).  As for an authorship line, I tend to omit those (they quickly go
> stale, and git history is sufficient for a much more accurate picture);
> the copyright line is more important legally than any author line.

Ok, I have added a Xilinx copyright line and not bothered with a
written by line.

Thanks for your help.

Thanks,

Alistair

>
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>