From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWCIY-0000N6-6f for qemu-devel@nongnu.org; Wed, 17 Feb 2016 19:18:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWCIS-0004dA-I2 for qemu-devel@nongnu.org; Wed, 17 Feb 2016 19:18:22 -0500 Received: from mail-ob0-x234.google.com ([2607:f8b0:4003:c01::234]:35887) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWCIS-0004d6-DD for qemu-devel@nongnu.org; Wed, 17 Feb 2016 19:18:16 -0500 Received: by mail-ob0-x234.google.com with SMTP id gc3so40945822obb.3 for ; Wed, 17 Feb 2016 16:18:16 -0800 (PST) MIME-Version: 1.0 Sender: alistair23@gmail.com In-Reply-To: <56C50C43.7060201@redhat.com> References: <174e5d40f6c59bf57ea997c0575f21b8b67ce5d6.1455739133.git.alistair.francis@xilinx.com> <56C4E923.9000306@redhat.com> <56C50C43.7060201@redhat.com> From: Alistair Francis Date: Wed, 17 Feb 2016 16:17:46 -0800 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v1 2/2] generic-loader: Add a generic loader List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Peter Maydell , "qemu-devel@nongnu.org Developers" , Alistair Francis , Peter Crosthwaite , Christopher Covington , Paolo Bonzini , lig.fnst@cn.fujitsu.com On Wed, Feb 17, 2016 at 4:11 PM, Eric Blake wrote: > On 02/17/2016 05:03 PM, Alistair Francis wrote: > >>>> +++ b/hw/misc/generic-loader.c >>>> @@ -0,0 +1,127 @@ >>>> +/* >>>> + * Generic Loader >>>> + * >>>> + * Copyright (C) 2014 Li Guang >>>> + * Written by Li Guang >>> >>> Want to claim 2016? >> >> Yep, I can do that. I'm never too sure when this can be changed or >> not. Should I add a written by as well? > > I'm not a lawyer, so my response may not be authoritative; in > particular, your employer may have specific rules that you must follow > for any code you submit that was written on your employer's time, and > that trumps anything I say here (that is, trust your lawyers more than > you trust me). > > But in general, I tend to go by the simple rule of listing the first > year that any of the code was first developed (if you are copying > significant portions from some other file, then use the starting year > from that file, even if your file didn't exist back then), through the > current year, if my change is non-trivial (more than 10 lines, or > altering an interface), while ignoring the issue for trivial things > (such as fixing a typo, or doing a bulk search-and-replace across the > tree). As for an authorship line, I tend to omit those (they quickly go > stale, and git history is sufficient for a much more accurate picture); > the copyright line is more important legally than any author line. Ok, I have added a Xilinx copyright line and not bothered with a written by line. Thanks for your help. Thanks, Alistair > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >